Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VS 2022 Support #2917

Merged
merged 4 commits into from Jul 31, 2021
Merged

VS 2022 Support #2917

merged 4 commits into from Jul 31, 2021

Conversation

jaredpar
Copy link
Collaborator

This commit adds the initial support for VS 2022 into the main tree.
This is pretty straight forward with the shared project approach now.
There was a single test failure in folds that I need to track down but
that's about the only issue I hit.

A lot of credit goes to @vivlimmsft in commit
17b98f2. That is the work that got
VsVim into VS2022 Preview 1. The work involved convinced me that the
shared project approach was necessary going forward. This PR is
effectively doing that and completing the Preview 1 work.

This commit adds the initial support for VS 2022 into the main tree.
This is pretty straight forward with the shared project approach now.
There was a single test failure in folds that I need to track down but
that's about the only issue I hit.

A lot of credit goes to @vivlimmsft in commit
17b98f2. That is the work that got
VsVim into VS2022 Preview 1. The work involved convinced me that the
shared project approach was necessary going forward. This PR is
effectively doing that and completing the Preview 1 work.
The `DTE.Commands` method is throwing a `MissingMethodException` in VS
2022 Preview 2. Abstract the call out to a place where we can safely
catch that exception for now. Working to find out what the problem is
here.
@Kethku
Copy link

Kethku commented Jul 26, 2021

Super excited for this as not having a working extension in 2022 has been defacto blocking my ability to work in vs.

Some things I noticed:

  • the cursor feels thinner when in insert mode. I'm guessing something changed...
  • the options window for setting keybindings is weird now. It kinda flickers and its hard to click buttons or w/e

If you'd like I can raise separate issues for these, just figured I'd let you know here.

@Kethku
Copy link

Kethku commented Jul 29, 2021

Also oddly immediately after installing, things worked fine, but then after a restart, I can't open text documents with the extension enabled. VS freezes and doesn't recover

@Kethku
Copy link

Kethku commented Jul 29, 2021

Weirdly reinstalling seems to cause it to work again until I restart

@jaredpar jaredpar merged commit 70477d3 into master Jul 31, 2021
@jaredpar jaredpar deleted the dev/jaredpar/vs2022 branch July 31, 2021 11:29
@jaredpar
Copy link
Collaborator Author

@Kethku

Sorry, been out for the last week. Just getting back to things

the cursor feels thinner when in insert mode. I'm guessing something changed...

It's possible this has changed but it wouldn't be due to VsVim. For insert mode VsVim actually just lets Visual Studio draw the caret. They did revamp the UI a bit though so it's possible they made changes here.

the options window for setting keybindings is weird now. It kinda flickers and its hard to click buttons or w/e

That one I hadn't noticed. It's likely this is still a VS issue vs. a VsVim one but please file a tracking issue so I don't lose track of it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants