Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

100% progress bar colour (in dark mode) same as 0% #488

Closed
mylogon341 opened this issue Aug 26, 2022 · 8 comments
Closed

100% progress bar colour (in dark mode) same as 0% #488

mylogon341 opened this issue Aug 26, 2022 · 8 comments

Comments

@mylogon341
Copy link

I'm running dark mode and find that the 100% progress bar to be a bit confusing. It doesn't catch my attention to handle 100% items as, at a glance, it looks the same as something that is stuck at 0%. Would it be possible to please leave the lighter green background to fill, or possibly choose a different colour all together so it draws my attention?

Thanks

Screenshot 2022-08-26 at 11 46 45 am
Screenshot 2022-08-26 at 11 46 56 am

(I dont have anything stuck fully at 0% atm, so this is the closest I have)

@DanielBiegler
Copy link
Contributor

I find this reasonable and a good idea. I'm currently taking a look at how to do this.

@DanielBiegler
Copy link
Contributor

So I've identified that we can just change the theme colors and it works! :)

image

Here I've changed it to the downloading-color and it looks clearer than the darker green imo.

@WDaan I also thought about setting to something else so its even clearer but pretty much all distinct colors are already in use. So it leaves only pretty stark colors like this:

image

Whats your take on it?

@mylogon341
Copy link
Author

That purple looks good but I think it's already used for the 'metadata' phase of a magnet torrent, right?

@DanielBiegler
Copy link
Contributor

It's similar but not the same. Metadata is 7e57c2 which is more purple and the new completed is 9b3184 is more magenta/pinkish, see here:

image

You can find the color settings here.

@mylogon341
Copy link
Author

Hmm. Yea they seem too similar imo, which kind of brings back to the same issue. I wonder if it'd be worth using something like material design as a reference
https://material.io/design/color/the-color-system.html#tools-for-picking-colors
There are some good example pallets on there to pick from and they show the suggested text colour to use against them for visibility as I think that's an issue too with some choices (in regards to contrast). For example.
Screenshot 2022-10-15 at 10 46 09 pm
Screenshot 2022-10-15 at 10 43 25 pm

@DanielBiegler
Copy link
Contributor

Hey good idea with the material colors, I like them. You got a prefered palette in mind? I'll update the PR then.

@WDaan
Copy link
Collaborator

WDaan commented Oct 16, 2022

thanks for the suggestion @mylogon341

@WDaan
Copy link
Collaborator

WDaan commented Oct 19, 2022

Are we going with a material palette?

@DanielBiegler DanielBiegler removed their assignment Aug 10, 2023
@Larsluph Larsluph mentioned this issue Oct 7, 2023
@WDaan WDaan closed this as completed Oct 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants