Vue3 rewrite #1128
Merged
Vue3 rewrite #1128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Create empty Navbar - Locale select: use store - Import Vuetify custom themes - Create app store - Create modals store - Create vuetorrent store
FIXME: system theme update event still fires after remove
Changed data table to list
WDaan
approved these changes
Oct 7, 2023
|
This is amazing! I'll merge it to the current vue3 branch, so we can make it a working version again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a complete rewrite of the current
vue3branch.I took the liberty of starting from scratch because I saw that neither the current branch nor known forks were active at the time I decided to focus on that subject.
I started this rewrite only to learn about Vue3, the composition API, reactivity and all related stuff. I thought that because the current version isn't building / working properly, is inactive for a bit now and that I already had a working POC, I'd continue building on top of what I was already familiar with.
This rewrite contains pretty much everything that was available based on the
1.7.0version. I already added some stuff that was merged after that but not everything.Fixes #734 (Vue3 migration)
Fixes #60 (keyboard navigation on content tab)
Fixes #488 (color diff between 0% downloading and 100% done)
Fixes #532 (external IP address)
Fixes #606 (follow system theme)
Fixes #728 (tracker color by status)
Fixes #749 (global add torrent waitlist)
Fixes #872 (match default date format to ISO 8601)
Fixes #890 (Add modal flags doesn't default to qbit settings)
Fixes #938 (peer list copy IP / port)
Fixes #961 (Spacing in torrent card)
Fixes #965 (old regression from Vuetify 2)
Fixes #971 (batch selection of torrents in dashboard)
Fixes #1010 (Add warning text on delete files)
Fixes #1018 (Add custom search composable)
Fixes #1066 (Wrap dashboard properties title)
Fixes #1119 (Make useful text selectable: hashes, urls and similar)