Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Control content tab use keyboard #216

Closed
wants to merge 8 commits into from
Closed

Control content tab use keyboard #216

wants to merge 8 commits into from

Conversation

m4ximuel
Copy link
Contributor

@m4ximuel m4ximuel commented Apr 15, 2021 •
edited
Loading

Control content tab use keyboard [feat]

  • Move the list index with the up and down arrow keys
  • Expand/collapse the list with the left and right arrow keys
  • Toggle exclude/include files with space and enter keys

PR Checklist

  • I've started from master
  • I've only committed changes related to this PR
  • All Unit tests pass
  • I've removed all commented code
  • I've removed all unneeded console.log statements

m4ximuel and others added 6 commits April 15, 2021 13:21
@m4ximuel @WDaan
fix: layout issues + remove vue-perfect-scrollbar + refactor context …
95b1019 
…menu

fix: issue where 'torrent details' modal does not work properly on iOS
perf: 'Vue2-perfect-scrollbar' is no longer dependent
feat: checkbox with color featback for TorrentDeleteModal
perf: Context (right click) menu refactor! Works way better on mobile
@m4ximuel
Feat: New Logo
3df8b68
@WDaan
chore: readme alignment fixes
0a56a9e
@WDaan
chore: fix readme mention
f61171b
@m4ximuel
Merge branch 'master' of https://github.com/WDaan/VueTorrent
25f67d6
@m4ximuel
Update Content.vue
9018ac9
@m4ximuel m4ximuel mentioned this pull request Apr 15, 2021
Closed
@m4ximuel
Copy link
Contributor Author

@WDaan I thought I made a PR from the 'master', but there is an unexpected history. Shall I make a new PR?

@WDaan
Copy link
Collaborator

WDaan commented Apr 15, 2021

No it's fine :) it only shows changes related to this PR. That's what matters.

I will test this out tomorrow! It looks impressive.

@m4ximuel
Copy link
Contributor Author

m4ximuel commented Apr 15, 2021 •
edited
Loading

@WDaan I found a bug in the treeview.
Items with the same file name are not selected at the same time, but items with the same folder name are selected at the same time. Please solve this problem.

@m4ximuel
Copy link
Contributor Author

@WDaan Functionally, it is complete, but please review whether that part of the bug is a fixable problem. I can't modify the treeview structure because it can't be interpreted.

@WDaan
Copy link
Collaborator

WDaan commented Apr 18, 2021

What do you mean by "it can't be interpreted"?

@m4ximuel
Copy link
Contributor Author

What do you mean by "it can't be interpreted"?

I don't know how to edit tree data.

@WDaan
Copy link
Collaborator

WDaan commented Apr 18, 2021

The 'tree' is generated with the treeify function. Once it's generated and passed into component, you cant do much with it anymore.

That's why I would like to get rid of the v-treeview component & look for another solution. One where we have more control over what happens

@m4ximuel
Copy link
Contributor Author

@WDaan hmm... Could you fix the first bug I mentioned before looking for a another solution?

Items with the same file name are not selected at the same time, but items with the same folder name are selected at the same time.

It's out of my abilities. I can hardly understand the treeview.
Once you fix this, #60 can be closed satisfactorily.
Something... It seems to be possible to use the difference between the data included in the 'file' and the 'folder', but...

@WDaan
Copy link
Collaborator

WDaan commented Nov 15, 2022

Closed due to inactivity

@WDaan WDaan closed this Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@m4ximuel @WDaan