-
-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to Vue 3 (complete rewrite) #756
Conversation
This reverts commit 0c6b305.
62d5184
to
516ecfa
Compare
Seems like you pretty much started the project over and migrate components. I'm not that big a fan of that approach because we'll have to do a tons of things over all over again. However, when following the migration docs I've noticed that it's a bit harder to get everything working again than anticipated. I'm a bit at a crossroads right now. |
Well vue 3 dropped support for several things, I also chose to do it in the composition api instead of options (the vue 2 way) because leads to IMO cleaner code with less boilerplate. Also vuetify had a massive overhaul so v-flex is now non-existent and several of the customization options like for v-layout also do not exist. Also I chose to redo the way that data is fetched from qbit is a better way using vue-query, it handles deduping and requerying for us, as well as a few other benofits. Not to mention the fact that vuex is being replaced with pinia and having one massive store is a bad practice, so I am fragmenting it into more stores so components don't pull more data than they need. Vite has been configured to to perform code splitting (faster load times) which you chose to disable |
Seems like redoing is indeed the better path, unfortunately. (Because it requires a lot of effort before we can merge to main and actually see some of the result/benefits) But we can cleanup and redesign a lot more this way, which is nice. |
Migrate to Vue 3