Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests running not in UTC Timezone #912

Closed
basil-gor opened this issue Jun 14, 2024 · 1 comment
Closed

Tests running not in UTC Timezone #912

basil-gor opened this issue Jun 14, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@basil-gor
Copy link
Contributor

Describe the bug
I noticed, that tests are running not in the UTC timezone.

To Reproduce
Steps to reproduce the behavior:

  1. Change the timezone on the local machine to a negative offset.
  2. Run tests.
  3. You will notice that some tests fail. For example tests/unit/components/Datepicker.spec.ts > Logic connection > Should select date

And most interesting, if you push a commit with changes while using a negative timezone, GitHub will also run these tests in the same timezone, causing them to fail. This issue occurred in my job here: https://github.com/Vuepic/vue-datepicker/actions/runs/9514864890/job/26227911555

Suggested Solution
To ensure consistency and avoid timezone-related issues, we should configure tests to always run in the UTC timezone.

@basil-gor basil-gor added awaiting triage The issue is not reviewed by the maintainers bug Something isn't working labels Jun 14, 2024
@basil-gor
Copy link
Contributor Author

I didn't change the tests, but I pushed an unrelated commit that shouldn't have broken them, yet the tests failed.
This means technically any commit made west of London's timezone could be affected.

@Jasenkoo Jasenkoo removed the awaiting triage The issue is not reviewed by the maintainers label Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants