Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Strings lowercased because of missing en "translations" after tap:18n port #555

Closed
anthonymayer opened this issue Nov 26, 2014 · 1 comment
Closed

Strings lowercased because of missing en "translations" after tap:18n port #555

anthonymayer opened this issue Nov 26, 2014 · 1 comment

Comments

@anthonymayer
Copy link
Contributor

Strings I've found so far:
"view" in nav
"best" in view menu
"load_more" on search
default view options need to be run through i18n

screen shot 2014-11-25 at 10 28 22 pm
@SachaG SachaG added the i18n label Nov 26, 2014
@anthonymayer
Copy link
Contributor Author

I changed my mind on figuring out how to uppercase the default view options. I tried using i18n.t(), but that caused a compile issue and then I realized that none of the settings are i18n'd anyway so I just didn't bother making it work.

@SachaG SachaG closed this as completed in 55f151b Nov 26, 2014
SachaG added a commit that referenced this issue Nov 26, 2014
@SachaG
Merge pull request #556 from anthonymayer/missing_i18n_keys
b6d9994 
Fixes #555.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@SachaG @anthonymayer