Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple "please log in" messages #868

Closed
SachaG opened this issue Mar 31, 2015 · 2 comments
Closed

Multiple "please log in" messages #868

SachaG opened this issue Mar 31, 2015 · 2 comments
Labels

Comments

@SachaG
Copy link
Contributor

SachaG commented Mar 31, 2015

Here's a bug for you: When signed out, if a user is viewing a post with nested comments and clicks the upvote or downvote buttons the system will produce a message asking the user to login first. If the click is on what I will call a level one comment (for example, the first comment in this thread by 9ball) one message will be generated. If however, the user clicks on a second level comment (for example, your reply to 9ball that begins, "We could consider...") then two messages will be generated. The pattern is now established, if third level, three messages, and so on. Should be an easy fix and make the page look a little more professional to the unregistered.

@SachaG SachaG added the bug label Mar 31, 2015
@SachaG
Copy link
Contributor Author

SachaG commented Mar 31, 2015

This is happening because of the multiple nested comment_item templates. I made a reproduction here if anybody is curious: http://meteorpad.com/pad/yaKMTdGZYkCoGwbvu/Leaderboard

SachaG added a commit that referenced this issue Mar 31, 2015
@SachaG
Copy link
Contributor Author

SachaG commented Mar 31, 2015

Fixed :)

@SachaG SachaG closed this as completed Mar 31, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant