Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix e-mail template overrides by adding the "custom" prefix server-side #1159

Merged
merged 1 commit into from Oct 13, 2015
Merged

Fix e-mail template overrides by adding the "custom" prefix server-side #1159

merged 1 commit into from Oct 13, 2015

Conversation

garyttierney
Copy link
Contributor

Separate template replacement from adding the initial "custom" prefix,
so that server-side templates (namely e-mails) can also have overrides.

Seperate template replacement from adding the initial "custom" prefix,
so that server-side templates (namely e-mails) can also have overrides.
@garyttierney
Copy link
Contributor Author

Bit of context to this: the custom_ prefix is only ever registered on the client. Since telescope-email manages templace replacements itself it never finds the prefix.

To reproduce, create and add a new "custom_emailWrapper.handlebars" to a package, any changes made won't be reflected on your server.

The solution is to move Telescope.config.addCustomPrefix("custom_"); to a JS file required on both the client and server.

SachaG added a commit that referenced this pull request Oct 13, 2015
…emplates

Fix e-mail template overrides by adding the "custom" prefix server-side
@SachaG SachaG merged commit 20492a5 into VulcanJS:devel Oct 13, 2015
@SachaG
Copy link
Contributor

SachaG commented Oct 13, 2015

Makes sense, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants