Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow the ApolloEngine LogLevel to be set via the settings #1810

Merged
merged 2 commits into from Jan 11, 2018

Conversation

luhagel
Copy link
Contributor

@luhagel luhagel commented Jan 11, 2018

Some eslint formatting crept in, bloats the diff, but since it's just following the eslintrc, it should be done sooner or later anyway ;)

@SachaG
Copy link
Contributor

SachaG commented Jan 11, 2018

Thanks! Before I accept this though, could you also document the setting by registering it with registerSetting?

For example:

registerSetting('apolloEngine.logLevel', 'INFO', 'Log level (one of INFO, DEBUG, ...');

@luhagel
Copy link
Contributor Author

luhagel commented Jan 11, 2018

sure thing

@SachaG SachaG merged commit 0384122 into VulcanJS:devel Jan 11, 2018
@SachaG
Copy link
Contributor

SachaG commented Jan 11, 2018

Awesome, thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants