Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support email headers property and simplify logic #2087

Merged
merged 2 commits into from Sep 26, 2018

Conversation

mousetraps
Copy link
Contributor

@mousetraps mousetraps commented Sep 26, 2018

Headers are defined as in meteor docs:
https://docs.meteor.com/api/email.html

This change enables you to set additional properties from VulcanEmail.buildAndSend, like "sender"

Tested in both simulation and non-simulation modes by setting the "sender" header with mailgun.

{
  emailName: 'test',
  ...
  headers: {
    sender: 'User Name <user@mydomain.com>'
  }
}

@SachaG
Copy link
Contributor

SachaG commented Sep 26, 2018

Oh thanks! And thanks for updating both ways of calling the function.

@SachaG SachaG merged commit 68a956a into VulcanJS:devel Sep 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants