New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add /i18n debug page #2091
Add /i18n debug page #2091
Conversation
This is great! Will be very useful for my projects, too :) And I think |
This makes me think, maybe we would need a |
Something like |
Yes that's what I had in mind. But maybe we can still use |
That makes sense. addRoute({ name: 'redirection', path: '/settings', onEnter: (nextState, replace, callback) => replace(`/debug/settings`)}) Because the way things are done, any property you add to the argument of To come back to the changes I made in this PR: I made all the routes "side by side", but actually they should be parent/children right ? I could refactor maybe. I'm not using this personally and I don't really understand the point of having parent/child relation in a route, but I guess this could be a good example of implementation for this feature. |
Yeah let's wait until RR4 and open a new issue to discuss this feature. As for parent/child routes I also don't really get it, so I think we can leave it for now. |
Hi, Usually parent child relationship usually means nesting levels of layout. Eg you have your app layout, and a children is displayed depending on the route. Then, this children could also display smth depending on the route. It will indeed need further discussion, I am not really familiar with RR4 (nor fond of it...) and it is quite complex. I'll check the server part of Apollo 2 soon. |
I created a debug page for i18n strings. The route for it is
/i18n
The features are :
Components.datatable
Tell me if there are any additional features you can imagine and would like to be added.
If I can add a proposition about the debug package : all the routes should be renamed to
/debug/i18n
ordebugi18n
, ori18ndebug
(which is my favorite) to avoid conflicts with the routes set for the app. I don't think anyone will set a route called/i18n
, but a/settings
route is pretty common in any app. So if someone was to add it to their app, they would be unable to see the settings debug page. @SachaG if you like the idea I'll add this to the PR.If this gets merged I'll update the docs