Fixes #719. Allowing mobile nav to close if user clicks anywhere outside of it #724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ere outside of it. Also, adding test.
|
Uhh looks like there's some weirdness to how width is measured depending on how the test is run. This might be a velocity bug. I'll update this when the tests actually pass. Yay Travis catching test failures! |
anthonymayer
force-pushed
the
mobile-nav-click-outside
branch
from
2396466
to
ff3ed6a
Compare
anthonymayer
added a commit
that referenced
this pull request
Jan 28, 2015
Fixes #719. Allowing mobile nav to close if user clicks anywhere outside of it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, adding test.