remove HeadTags from core components

VulcanJS · Sep 28, 2022 · 345ab21 · 345ab21 · vercel · Sep 28, 2022
1 parent e1a9759
commit 345ab21
Show file tree

Hide file tree

Showing 6 changed files with 102 additions and 98 deletions.
diff --git a/docusaurus/docs/vulcan-meteor-legacy/features/head-tags.md b/docusaurus/docs/vulcan-meteor-legacy/features/head-tags.md
@@ -2,6 +2,10 @@
 title: Head Tags
 ---
 
+/!\ In Vulcan Next and Vulcan NPM, 
+we don't provide Head Tags anymore,
+because modern frameworks already provide their own solution at app-level
+
 You'll often need to add tags to your app's `<head>` section. There are three ways to do this: using the [Helmet](https://github.com/nfl/react-helmet) library, using the `<Components.HeadTags/>` component, or using the `Head` object. 
 
 ## Helmet

diff --git a/packages/react-ui-lite/components/VulcanComponents/liteVulcanComponents/coreComponents.ts b/packages/react-ui-lite/components/VulcanComponents/liteVulcanComponents/coreComponents.ts
@@ -1,5 +1,5 @@
 import { FormattedMessage } from "@vulcanjs/react-i18n";
-import { Button, Loading, HeadTags, TooltipTrigger, Alert } from "../../core";
+import { Button, Loading, TooltipTrigger, Alert } from "../../core";
 
 import {
   defaultCoreComponents,
@@ -19,6 +19,5 @@ export const liteCoreComponents: Partial<PossibleCoreComponents> = {
   // i18n
   FormattedMessage,
   // core
-  HeadTags,
   TooltipTrigger,
 };
diff --git a/packages/react-ui-lite/components/core/HeadTags.tsx b/packages/react-ui-lite/components/core/HeadTags.tsx
@@ -1,5 +1,8 @@
+/**
+ * @deprecated HeadTags are not exposed anymore,
+ * copy paste this logic and adapt to your app if you need HeadTags
+ */
 import React, { PureComponent } from "react";
-import PropTypes from "prop-types";
 // import { Helmet } from 'react-helmet';
 // import { registerComponent, Utils, getSetting, registerSetting, Head } from 'meteor/vulcan:lib';
 // import compose from "recompose/compose";

diff --git a/packages/react-ui-lite/components/core/index.ts b/packages/react-ui-lite/components/core/index.ts
@@ -1,5 +1,4 @@
 export { Button } from "./Button";
 export { Loading } from "./Loading";
-export { HeadTags } from "./HeadTags";
 export { TooltipTrigger } from "./TooltipTrigger";
 export { Alert } from "./Alert";
diff --git a/packages/react-ui/components/VulcanComponents/typings.ts b/packages/react-ui/components/VulcanComponents/typings.ts
@@ -97,7 +97,6 @@ export interface PossibleCoreComponents {
   // TODO: define props more precisely
   MutationButton: any; //React.ComponentType<MutationButtonProps>;
   LoadingButton: React.ComponentType<any>;
-  HeadTags: React.ComponentType<any>;
   // Previously from Bootstrap and Mui
   TooltipTrigger: React.ComponentType<any>;
   Dropdown: React.ComponentType<any>;