Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework of the Python Filter (Depends on PR Support UDP TCP #224) #232

Draft
wants to merge 17 commits into
base: support_tcp_udp
Choose a base branch
from

Conversation

ThibaudCartegnie
Copy link
Contributor

✨ Pull Request Template

‼️ Once all the checklist is done you have to:

  • stash merge this pull request
  • delete the corresponding branch
  • close the associated issue

📃 Type of change

Please delete options that are not relevant.

Breaking change: fix or feature that would cause existing functionality to not work as expected.

💡 Related Issue(s)

✒️ Description

Reworks the python filter to be closer of what we need and easier to use.

🎯 Test Environments

FreeBSD - Vulture ISO (12.2)

  • Redis (6.2.6)
  • Boost (1.72.0)
  • clang++(10.0.1)
  • CMake (3.21.3)
  • Python (3.8.11)

Ubuntu (20.04)

  • Redis (5.0.7)
  • Boost (1.71.0)
  • g++ (9.3.0)
  • CMake (3.16.3)
  • Python (3.8.10)
  • Valgrind (3.15.0)

✔️ Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • (If new filter) I have added corresponding page to the documentation
  • (If other changes) I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

  • 🙋 I certify on my honor that all the information provided is true, and I've done all I can to deliver a high-quality code

@ThibaudCartegnie ThibaudCartegnie changed the base branch from dev to support_tcp_udp February 1, 2022 14:25
samples/fpython/fpython.hpp Outdated Show resolved Hide resolved
tests/tools/filter.py Outdated Show resolved Hide resolved
samples/fpython/Generator.hpp Outdated Show resolved Hide resolved
samples/fpython/Generator.hpp Outdated Show resolved Hide resolved
samples/fpython/Generator.cpp Outdated Show resolved Hide resolved
}
}
for(auto cert: resp.certitudes) {
_packet.AddCertitude(cert);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stats' support might be complicated with this filter, bu I think you could add a STAT_MATCH_INC; for each certitude over threshold

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added it

samples/fpython/PythonTask.cpp Outdated Show resolved Hide resolved
cmake/fpython.cmake Outdated Show resolved Hide resolved
samples/fpython/PythonThread.hpp Outdated Show resolved Hide resolved
tests/filters/fpython.py Outdated Show resolved Hide resolved
example.py is made a better example to test the filter
Added logger to example
added support for venv
updated cmake min version
- now expects a class (see algorithm_module.py)
- added tests for class specific issues
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants