Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AWS tags allow content that is not permitted in Kubernetes labels #1

Open
emmanuel opened this issue Mar 4, 2016 · 1 comment
Open

AWS tags allow content that is not permitted in Kubernetes labels #1

emmanuel opened this issue Mar 4, 2016 · 1 comment

Comments

@emmanuel
Copy link

emmanuel commented Mar 4, 2016

There is no validation performed on the tag content before attempting to apply it to the Kubernetes node. Put a space in your EC2 tag key or a value over 63 characters, etc., then boom! Your labelgun is in a crash loop.

Might at least be worth a mention in the README.
@feelobot
Copy link
Contributor

thanks @emmanuel I will work on some validation!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@emmanuel @feelobot