Add archive page & other perks #68
Conversation
Add link in index to archive page Return google analytics to head since it is async
Plus add actual html tags and define the lang for better accessibility
|
Nice job @coltborg! A few questions:
|
|
I AM SO EXCITED TO SEE THIS!!! @coltborg!!!! @tomsapps agree the spacing is a bit awkward between the header, subhead, and list of talks. Rather than adjusting the spacing, though, since it's following the style from the home page, can the subhead just get longer?
|
|
@beckyrother making the subhead longer is a good idea! I've never thought of that; My mind is actually blown lol |
|
@brianmontanaweb Taking a look at Jekyll for the first time and I'm wondering if we really need it right now? I was thinking we could write a loop that would parse a config file containing objects with |
|
@brianmontanaweb @tomsapps @coltborg is the work done here sufficient to merge or is there yet more to do before it's ready for primetime? |
|
I'll verify the PR over lunch and test locally first
On Apr 16, 2018 11:21 PM, Vwampage <notifications@github.com> wrote:
@brianmontanaweb<https://github.com/brianmontanaweb> @tomsapps<https://github.com/tomsapps> @coltborg<https://github.com/coltborg> is the work done here sufficient to merge or is there yet more to do before it's ready for primetime?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#68 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AEc11sWM-M_GGnacb0P3bCtZv302zJkJks5tpW20gaJpZM4SlJMu>.
|
|
All good, verified it works and looks good locally 👍 |
|
O SHIT HERE COME DAT MERGE. |
Summary
Hello @Vwampage & @beckyrother 👋
I've create a new page and added some bells and whistles ✨
Main Feature
The main addition is a new archive page. I took information for previous git commits and issues submitted by @brianmontanaweb. Not everyone has slides, but they can be added in the future.
Link on home page
I don't know y'all want the link to the archive page from the home page, so I added it toward the end of the page:
Preview of archive page
More links to slides to come in the future. I tried to use the existing design patterns as much as possible. Here's a preview of the entire archive page:
Some additional perks
Editor Config
I added an
.editorconfigfile so that anyone who develops the website will have consistent spacing and line returns. For example, before theindex.htmlused tabs whilestyle.cssused spaces. Now all files should be consistent and future files will stay in line. More information about editorconfig can be found on their website.Dynamic Footer Year
I added a small bit of JavaScript to keep the year in the footer current. We'll never have to worry about updating it.
More Meta Tags
I used the site heymeta.com to generate all the meta tags appropriate for the different social sites. So that when people share the url, there will be a nice preview (will probably show up in Slack too!)
Added
<html>I noticed there wasn't an actual
<html></html>tag. This is ok since the browser automatically adds it. But I added it just to be clear. I also added thelangattribute to be clear what language the site is in.Simple Readme
I added a small readme just have have showing on the github page. Nothing fancy here.