Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two different implementations of ÞR #1150

Closed
Tracked by #1119
cgccuser opened this issue Jun 23, 2022 · 2 comments · Fixed by #1175
Closed
Tracked by #1119

Two different implementations of ÞR #1150

cgccuser opened this issue Jun 23, 2022 · 2 comments · Fixed by #1175

Comments

@cgccuser
Copy link
Member

cgccuser commented Jun 23, 2022

There are currently two implementations of ÞR

  1. Remove the last item of the cumulative sums of a list and prepend 0.
  2. Reduce the rows of a by function b

I think the second is more general and worth keeping. The first is extremely specific.

(this was mentioned in the big bugs issue (test case [[]] : [0]))

@cgccuser cgccuser changed the title ÞR: [[]] : [0] Two different implementations of ÞR Jun 23, 2022
@Steffan153
Copy link
Contributor

Steffan153 commented Jun 24, 2022

I've used the first before (remove last of cumulative sums and prepend 0), so it can be useful. Reduce the rows of a by function b is useless, just vectorised reduce.

@cgccuser cgccuser added this to the The Great Bug Fix milestone Jun 24, 2022
@lyxal
Copy link
Member

lyxal commented Jun 25, 2022

Remove the last item of the cumulative sums of a list and prepend 0 seems like it should be kept because no need to have a digraph for

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants