Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement edit detection #44

Closed
wants to merge 27 commits into from
Closed

Implement edit detection #44

wants to merge 27 commits into from

Conversation

lyxal
Copy link
Member

@lyxal lyxal commented Mar 16, 2023

Closes #9

@gingershaped
Copy link
Contributor

gingershaped commented Mar 16, 2023 •
edited

runCommand cannot return a string, because not everything it handles is a reply.

@lyxal
Copy link
Member Author

lyxal commented Mar 16, 2023

That's why it's an Optional[str]

@lyxal
Copy link
Member Author

lyxal commented Mar 16, 2023

Admittedly, it should be str | int so that messages sent that aren't replies can have their ids bubbled up through the call stack

@lyxal
Copy link
Member Author

lyxal commented Mar 17, 2023

There we go, it returns Optional[str|int]

@lyxal lyxal marked this pull request as ready for review March 17, 2023 12:54
gingershaped
gingershaped requested changes Mar 22, 2023
View reviewed changes
vyxalbot2/__init__.py Outdated Show resolved Hide resolved
vyxalbot2/__init__.py Show resolved Hide resolved
@lyxal lyxal requested a review from gingershaped April 5, 2023 02:15
gingershaped
gingershaped previously approved these changes Apr 5, 2023
View reviewed changes
@gingershaped gingershaped dismissed their stale review April 5, 2023 02:27

Hit enter too early

@gingershaped
Copy link
Contributor

@lyxal If this breaks the bot it'll be your fault

@lyxal
Copy link
Member Author

lyxal commented Apr 5, 2023

Well duh

@gingershaped
Copy link
Contributor

Also, I'm on vacation right now; I'll merge when I get back so if anything breaks I can fix it.

@lyxal
Copy link
Member Author

lyxal commented Apr 5, 2023

👍

@gingershaped
Copy link
Contributor

I'd like to make sure that this isn't a result of this PR before merging

@gingershaped
Copy link
Contributor

gingershaped commented Apr 14, 2023 •
edited

No, I am not stalling, I'm just being thorough

PlaceReporter99
PlaceReporter99 approved these changes Jun 12, 2023
View reviewed changes
Copy link
Contributor

@PlaceReporter99 PlaceReporter99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine, although I am not an expert at this.

@gingershaped gingershaped changed the base branch from dev to main July 21, 2023 13:58
@gingershaped
Copy link
Contributor

This has been rolled into #113.

@gingershaped gingershaped deleted the add-edit-detection branch October 18, 2023 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PlaceReporter99 PlaceReporter99 PlaceReporter99 approved these changes

@gingershaped gingershaped gingershaped left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow edits to be watched
3 participants
@lyxal @gingershaped @PlaceReporter99