Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates and Additions #245

Open
wants to merge 26 commits into
base: master
Choose a base branch
from
Open

Updates and Additions #245

wants to merge 26 commits into from

Conversation

supmaxi
Copy link

@supmaxi supmaxi commented May 21, 2020

@W4RH4WK
Copy link
Owner

W4RH4WK commented May 21, 2020

Thank you for the input. If I find some time, I'll go over the changes and cherry-pick what seems suitable.

@FuccDucc
Copy link

FuccDucc commented Mar 17, 2023

Disabling "camsvc", Capability Access Manager Service, results in taskbar tray menu no longer working (completely disappearing, along with the date, time and other icons like network status, sound icon), so please remove this from your changes to disable-services.ps1 @supmaxi

** Confirmed at least on win11

@FuccDucc
Copy link

FuccDucc commented Mar 17, 2023

Besides the above thing, there are more things that will break due to the inclusion of a script (make_windows10_great_again.bat) in this PR that is clearly made by a guy who doesn't know what he is doing and included many retarded and dangerous procedures. Such as:

  • Deleting the entire C:\Program Files\WindowsApps folder contents at the line echo Deleting trash apps..., this essentially bricks Windows apps as then you can't restore UWP apps due to improper removal method and to get anywhere, you'll need to get Windows App Store from a reinstall or advanced recovery with a WIM image, in place upgrade, or something, after that. Not to speak of having to find a way to let it automatically regenerate the folder with original owner, permissions as it messed with those as well, which is another topic on tech forums when dealing with apps being its functionality is bricked on an OS. Besides that the script removes a person's apps and its datas without acknownledgement, prompt, permission or realisation that it's doing this, someone can lose their stuff and they didnt expect that to happen from a "Debloater", it would even delete and brick non-Windows defaultt apps so ones that aren't to be considered Windows OS bloat in any way, but personal apps. This entire integration has to be cut out or the script is unsafe and damaging.

** Btw, you seem to be just as ballsy as the author of this script. Your PR also removes the disabling comment from this line in remove-default-apps.ps1: #"Microsoft.WindowsStore" # can't be re-installed - what do you not understand of "can't be reinstalled".. equaling a bricking? The entire PR serves as a reminder to not blindly copy paste, merge, use or run (like i did in my tests) stuff on the internet or github, as some people are too young or clueless and just throw a load of risky shit together. Even the language of that script's author (make_windows10_great_again.bat) for how much he uses tough language and 'spyware' for many things that are known not to be it, or to be vital to the OS, is a telltale of their outlook and level in things.

  • Don't mess with Windows Search, remove the disabling of "WSearch" service. It's one of the most common basic OS features that an user relies on, it will stop all indexing and make launching files and apps harder.

Besides that, stop the use of:

  • sc delete (setting startup type to 'Disabled' is sufficient).. if an user notices broken functionality or something they needed in some way, they should always have the power to easily undo it, and fix up what shouldn't have been disabled in their case. In my case, i continued to rely on WER (Windows Error Reporting) service called "WerSvc" as being a developer requires the ability to generate exception & crash dump files for applications, now i need an in-place upgrade of Windows to restore the service as it's no longer installed. If it was only set to disabled and stopped, it would've been easier to recover from.

For small things, on the line echo | set /p=Checking permissions... begins a faulty permissions check that in my test case will always return a failure even when running elevated as admin. I had to cut it out for proceeding.

And after all, following my tests i still noticed some broken OS functionality that im yet to pinpoint back to an exact procedure. For example, a network connection is detected with a delay (both on taskbar icon and certain applications that initially report there's no connectivity but then retract it after another try) and for a long time after running this stuff, consistently after each time i run it (make_windows10_great_again.bat) i couldn't open any Windows Explorer windows to a folder.. so because the main process that draws desktop and taskbar is in a different explorer.exe process than other content windows (so this part of the same script is a lifesaver that compensates for some other damage inflicted by the script itself:

echo | set /p=Launch folder windows in a separate process 
reg add "HKCU\SOFTWARE\Microsoft\Windows\CurrentVersion\Explorer\Advanced" /v "SeparateProcess" /t REG_DWORD /d 1 /f > nul
echo [OK]
  • which sets it to that, to be launching folder windows in a different process, i was still able to get a degree of functionality out of my PC, as it would draw my desktop but just not let me open any folder window or run "File Explorer". I found no way to resolve the folder window not working directly (actually: explorer.exe was crashing.. every time i attempted to open one. Yet the lack of WerSvc service didnt let me investigate it easily by any crash info), despite looking at & reverting some clear Explorer related manipulations the script performed to find a culprit. It only resolved over time, seemingly by itself (maybe a long Windows Self Repair detection and process), in the meanwhile i was only able to use the explorer alternative shell in Task Manager > create new process > browse, to aid with troubleshooting. So, if running this script, expect the self resolution to take anywhere upwards of an hour or even longer if you're not actively trying to interact with, and click, explorer related things. Who knows that it doesnt self resolve on all Windows environments for any reason (we dont know enough about it yet, maybe i was lucky a few times), so better dont dare it if you rely on your PC or dont want to be forced to reinstall. Unless someone identifies the culprit in the script so it can be cut out.

End of comment. As you can see, you are trying to contribute something that poses too many risks to the proper functioning of an OS. During my tests, i spent 100x more time investigating and hand-fixing obscure issues/breakages on this testing machine than i spent running relatively safe debloaters (like the warhawk one still is, so far) on hundreds of PC's combined, in the past year. I don't recommend anyone to merge or use this even locally, and i dont see it suitable for any relatively safe debloater repo. As the maintainer said to consider cherrypicking it, that is really the only way to go, so they can skim past the retarded lines and behaviors in the scripts you're trying to get added here. It really looks like a combination of random and cooked up stuff that an otherwise scriptkiddie-paster put together. That puts users at risk for messing up their OS for good, or damaging it for a lot of restoration efforts. Bruh @supmaxi

** Note that i didn't really review Harden OS.bat part of the PR yet. I expect it will contain some similar retarded, OS-corrupting procedures like the others mentioned, e.g made in a similar spirit by someone that doesn't know what he is doing. I also didn't review modifications and additions to existing warhawk debloaters. Not to speak of the least significant: you are duplicating a lot of functionality between those, and scripts like 'Harden OS' and make_windows10_great_again.bat .. its beyond what we can call messy. Making this PR is all just a big copy pasta operation.

Be careful with this stuff, @W4RH4WK

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants