Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash on accessing default_image_only_indicator #9

Merged

Conversation

blepping
Copy link
Contributor

@blepping blepping commented Mar 2, 2024

recent commit comfyanonymous/ComfyUI@cb7c3a2 removed the default_image_only_indicator attribute. this pull uses getattr to access it with a default value so it should be backwards compatible with revisions where the attribute actually exists/was required.

@LiJT
Copy link

LiJT commented Mar 4, 2024

Please review it!!!!

@BigUncle
Copy link

BigUncle commented Mar 4, 2024

@blepping, thank you to fix it.
@WASasquatch, please review it!
+1

@blepping
Copy link
Contributor Author

blepping commented Mar 4, 2024

thank you to fix it. [...], please review it! +1

unfortunately they haven't been active on GitHub for about a month so don't hold your breath. in the mean time, people can use this pull.

if you don't care about compatibility with older versions of ComfyUI (before the change that broke stuff) you can just change nodes.py line 159 from:

image_only_indicator = kwargs.get("image_only_indicator", self.default_image_only_indicator)

to

image_only_indicator = kwargs.get("image_only_indicator")

@BigUncle
Copy link

BigUncle commented Mar 5, 2024

thank you to fix it. [...], please review it! +1

unfortunately they haven't been active on GitHub for about a month so don't hold your breath. in the mean time, people can use this pull.

if you don't care about compatibility with older versions of ComfyUI (before the change that broke stuff) you can just change nodes.py line 159 from:

image_only_indicator = kwargs.get("image_only_indicator", self.default_image_only_indicator)

to

image_only_indicator = kwargs.get("image_only_indicator")

I have temporarily modified it according to your PR. It works.
Thank you again!

@WAS-PlaiLabs
Copy link
Collaborator

Thanks for the PR, sorry it took a bit. Been so busy, and for some reason half of GitHub notifications come in forum box vs my main box.

@WASasquatch WASasquatch merged commit 3ce68d4 into WASasquatch:main Mar 5, 2024
@BigUncle
Copy link

BigUncle commented Mar 5, 2024

@WASasquatch Thanks you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants