Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hidden pages show up in navigation #37

Closed
instantflorian opened this issue Aug 28, 2015 · 18 comments
Closed

Hidden pages show up in navigation #37

instantflorian opened this issue Aug 28, 2015 · 18 comments
Labels

Comments

@instantflorian
Copy link
Contributor

Pages with visibility setting "hidden" nevertheless shine up in navigation. Not good.

@NorHei
Copy link
Contributor

NorHei commented Aug 28, 2015

if i remember right this is an old WB error too

@webbird
Copy link
Contributor

webbird commented Aug 28, 2015

It comes up every now and then. SM2 has a setting for this.

@instantflorian
Copy link
Contributor Author

no, this error does definitively not shine up in WB, at least it does
not in Rev. 1641 - just checked it. Neither it does in earlier versions
of WBCE.

@instantflorian
Copy link
Contributor Author

Why has it been changed, then?

@NorHei
Copy link
Contributor

NorHei commented Aug 28, 2015

WB i such a funnie thing, letz check lates changes to show menu2

@marmotwb
Copy link
Contributor

Can't confirm that bug. Just tried it.

@NorHei
Copy link
Contributor

NorHei commented Aug 28, 2015

a look in the history says its only change is one run of code beautyfier....

@NorHei
Copy link
Contributor

NorHei commented Aug 28, 2015

Can't confirm here.
But i think i remember fixing something like that in one of my old forks , under certain circumstances hidden was not hidden ... Not sure if this was fixed somewhere in the 2.8.3 service packs. Itake a look at my archives.

@NorHei
Copy link
Contributor

NorHei commented Aug 28, 2015

MAybe you give us acces to your testpage ?

@instantflorian
Copy link
Contributor Author

sent via forum PM

@NorHei
Copy link
Contributor

NorHei commented Aug 28, 2015

for a quick test .. does this happen when logges in , not logged in , logged as Admin ?

@instantflorian
Copy link
Contributor Author

makes no difference

@NorHei
Copy link
Contributor

NorHei commented Aug 28, 2015

....hmmm there was something whith this showhidden thing

@NorHei
Copy link
Contributor

NorHei commented Aug 28, 2015

Ok Fist thing i found, WB_VERSION is 1.0.0 therefore line 585

if(version_compare(WB_VERSION, '2.7', '>=')) {

is never executed .

@NorHei
Copy link
Contributor

NorHei commented Aug 28, 2015

plus there are some more wbversion if then in the module

@NorHei
Copy link
Contributor

NorHei commented Aug 28, 2015

Is this really a recent version ?

@NorHei
Copy link
Contributor

NorHei commented Aug 28, 2015

if i remember right there are still some more bugs in show_menu2... but lets see after this one first

@instantflorian
Copy link
Contributor Author

Is this really a recent version ?
Argh! No, it isn't. My mistake, I'm sorry. Closing issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants