feat: Add OCR to detect mod names, retrieve plat prices from warframe.market #4
Conversation
…n already starting to hate it)
…images in test folder
|
Could be merged, but still needs a bit of work |
Sorry I just spent an hour debugging a stupid error (and I still don't know what caused it)
…hows the value FINALLY WORKS
|
I think the only thing left to add is some multithreading |
Tiebe
changed the title
src/main/java/gb/bourne2code/warframe/opencv/RunApplication.java
Outdated
Show resolved
Hide resolved
src/main/java/gb/bourne2code/warframe/opencv/recognise/DetectModInfo.java
Show resolved
Hide resolved
|
It's been 5 years so I'm excited someone is wanting to contribute towards this project, however much I had hoped the WF devs would have produced a public API endpoint to do what this project attempted to achieve. I agree with Tobi's comments, and I'm as guilty of not fully documenting my code when I did this, and looking back I struggle to remember some of the parts I wrote from 5 years ago. Given the lack of CI/CT I'm happy to help give the PR a test before merging down into main. |
|
yeah, could we look at doing a round of setting up tests with some test images and what they should output, with varying amounts of mods in them? |
|
Yeah, I believe there are already some test images in the test folder, I'll setup some tests later, and add all the javadocs of course. Problem with rivens is that their names are semi-randomized. Maybe I can split those names into parts and check each part separately. |
|
I have a regex someplace for rivens, I'll try to drop it in a comment on here. |
|
Awesome!! Thank you |
|
@Bourne-ID would you be horribly against re-scoping the packages to be like |
|
@TobiTenno None - Want me to action in a different PR or crunch the change with this one? If the prior then raise an issue against my name and I'll be happy to action it. |
yeah, makes more sense to do in a subsequent. so maybe throw out an issue and do it once we get this one and some good tests? |
src/main/java/gb/bourne2code/warframe/opencv/controllers/FileSelectController.java
Show resolved
Hide resolved
|
I don't think I'll be able to use OCR on rivens. It's because the colors on the image are so different, it requires a different image process to allow the OCR to read it at all, and since I can't know whether a mod is a riven or not, I won't be able to do this. Also, it will be hard to do a price estimation, since the prices for riven vary so much, because the better the stats the higher the price |
|
That should be all, could someone else review and test? |
|
i think bourne was going to. i'm good with it once they do, since I've not ever set this up before |
I believe I've made some changes so that you can run it by just pressing start on RunApplication#main without any special args or setup |
TobiTenno
changed the title
Head branch was pushed to by a user without write access
Add OCR for Mod names, still needs some work, check readme for TODO