Separate Notifications into Worker #270
Labels
released
Scope: Framework
Severity1: Critical
The defect affects critical functionality or critical data.
Status: In Progress
Work has Begun
Type: Enhancement
Comments
TobiTenno
added
Type: Enhancement
Scope: Framework
Severity1: Critical
|
not able to just read db, sadly, cause i gotta write out notified ids for now until I do some cleanup, but it's working! trying to make sure bot can still run on the same code, but having some issues after handlers are set up, so that'll take some fixing... but it's almost there! (then i can finally fix some other bugs) |
TobiTenno
added a commit
that referenced
this issue
Jun 7, 2020
* feat: move worker into separate process - make db calls flex between notifier worker and - wrap rest calls in a separate wrapper - fix MessageManagermisspelling - clean up logging - remove "deleteAfter" functionality for notifications BREAKING CHANGE: Notifier usage will need a new process and config * chore: decrease ctx lookup for non-bot scopes * fix: clean up fissures & arbi's are generated, move data generation into blocking part of script * task: bot working in parallel * feat: upgrade twitch notifier * refactor notifier to use notifiedIds db, clean up add build command, cleaner startup * fix: close #331, close #300, close #270 * chore: updates * chore: rebuild lock * improve twitter * chore: lint rss embed
wfcd-bot-boi
pushed a commit
that referenced
this issue
Nov 27, 2021
# 1.0.0 (2021-11-27) ### Bug Fixes * 2761272096, lfg settings nonexistent ([5b0ee5b](5b0ee5b)) * add default role missing descriptor, causing generation issues ([1b5403f](1b5403f)) * add fix the capture for default role ([df743c6](df743c6)) * add k for specific filtered words ([2a84331](2a84331)) * add sortie worldstate lookup. closes [#503](#503) ([aaf21a1](aaf21a1)) * always full uppercase requiem ages ([e656ca7](e656ca7)) * asset migration to cdn ([5ad7ae8](5ad7ae8)) * automatically do replaces instead of expecting user to know them ([d8ccf95](d8ccf95)) * bad naming ([fd5fdeb](fd5fdeb)) * bad owner & public mismatch ([d42207a](d42207a)) * bad syntax ([17b6a14](17b6a14)) * better filtering before creating joinable object ([b2cfb44](b2cfb44)) * better formatting for temp category ([ff96298](ff96298)) * cache pings for more invasion,item combinations. potential fix for [#498](#498) ([f63f78b](f63f78b)) * catch errors setting guild commands ([d618daa](d618daa)) * change "add" to "import" ([364141d](364141d)) * check both if there's a mod role and that there's an id ([d25959f](d25959f)) * check for webhook insert having invalid values, closes [#297](#297) ([4c31912](4c31912)) * **commands): track webhook init & check order fix(tracker): fix connection to external tracking systems chore: removing extra files fix(twitch:** better documentation and live checks for twitch ([6bc5084](6bc5084)) * custom commands not being accessible ([504c48e](504c48e)) * **darvo:** give darvo the right platform ([c9e3381](c9e3381)) * de-dupe platforms, spot-load user data ([fde50be](fde50be)) * directly output undecodable commands ([fedfbab](fedfbab)) * **djs12:** additional fixes for djs12, doc for control webhook ([76c4054](76c4054)) * **djs12:** caches ([b40f47f](b40f47f)) * **djs12:** channels cache ([8bf5fc4](8bf5fc4)) * **djs:** dump call cache ([18ca760](18ca760)) * **djs:** more cache fixes ([3ed3023](3ed3023)) * **djs:** more cache fixes ([f42c454](f42c454)) * don't include solaris bounty data in notification, check in case bounty data is empty ([215d088](215d088)) * **dump:** don't mention in messages ([4f5e99d](4f5e99d)) * embeds not showing all information in settings embeds, closes [#242](#242) ([f907b21](f907b21)) * empty platforms from config ([8149d8b](8149d8b)) * enable fissures, specify cache location ([0dc8717](0dc8717)) * ensure joinable settings are set on legacy roles ([426798c](426798c)) * existentially check user creation date ([dfa7142](dfa7142)) * extra filter on role fetch from db ([f95f3d9](f95f3d9)) * filter some errors ([6cf671f](6cf671f)) * fix for saving complex instead of simple roles ([56e4990](56e4990)) * flex frame embed fields for abilities, passive, and profile ([72f9a22](72f9a22)) * flex on description or mod effect ([#395](#395)) ([86eae6c](86eae6c)) * handle avatar hashes (closes [#442](#442)) ([5a4a98b](5a4a98b)) * handle missing guild when generating custom commands ([5889109](5889109)) * help triggering /h on lfg ([590406f](590406f)) * **i18n:** New Crowdin updates ([#501](#501)) ([a058ced](a058ced)) * ignore perm issues from setting guild ccs ([9d6e041](9d6e041)) * incorrect cycle data for cetus ([09ea0da](09ea0da)) * inline commands not registering properly ([4466e9b](4466e9b)) * integration filter, closes [#456](#456) ([a68f307](a68f307)) * interactions in dms. closes [#504](#504) ([9f772e0](9f772e0)) * let invalid mods fail command ([954b207](954b207)) * LFG not updating accurately ([af4a77f](af4a77f)) * **lfg:** check if initial embed is created, leverage direct calls ([aeeb07d](aeeb07d)) * **license:** badge saying the wrong thing ([1593cbf](1593cbf)) * logic around removing guilds from the db ([66c39c0](66c39c0)) * make custom statuses work better ([bc64a30](bc64a30)) * malperformant alerts for tweets, some missing commands ([d2f72e7](d2f72e7)) * message component existence, weird embed issues ([243eb6b](243eb6b)) * misc existential fixes, support compactable ([99d0852](99d0852)) * misc fixes to bad api calls ([ec9c17c](ec9c17c)) * more ping cache fixes. additionally for [#498](#498) ([07601f6](07601f6)) * more userinfo fixes ([8b27e7f](8b27e7f)) * news object fields ([ce63d63](ce63d63)) * **news:** fix some streams posting as updates ([e902556](e902556)) * not being able to leave/join roles ([5aeed39](5aeed39)) * not fetching properly ([6b68e7d](6b68e7d)) * **notifier:** add awaits on send ([22d7125](22d7125)) * **notifier:** guild id resolution ([e764289](e764289)) * notifying owner on bot-join ([f6ae100](f6ae100)) * numbers being miscalculated on secondary fires ([41db06c](41db06c)) * overly long whereis names ([f7b7679](f7b7679)) * package.json & package-lock.json to reduce vulnerabilities ([#313](#313)) ([1091aeb](1091aeb)) * **pencil:** colon or question mark for left or right ([c804ca2](c804ca2)) * **pencil:** custom command listing not always dumping properly. ([c9d3cd1](c9d3cd1)) * **pencil:** extermination -> exterminate ([baf990e](baf990e)) * **pencil:** extermination -> exterminate ([bbe9035](bbe9035)) * **pencil:** remove extraneous file ([fdfe13c](fdfe13c)) * **pencil:** set category not being prioritized when creating channels ([3387dae](3387dae)) * Position new channel below template ([811258d](811258d)) * primeaccess fixes ([aa1a945](aa1a945)) * private function invocation ([1359192](1359192)) * process per-shard instead of all shards at once ([71753cb](71753cb)) * promocode list errors ([28cda5f](28cda5f)) * queries, remove excess deps ([a4acf0d](a4acf0d)) * remove broken broadcaster call ([c9106ac](c9106ac)) * remove extra debug ([4b138b3](4b138b3)) * **roles:** roles.cache in addRole ([e5a926a](e5a926a)) * scale pages in settings from content lengths ([28951e3](28951e3)) * sentient outpost embed ([eca16af](eca16af)) * sentry error 2760182145, bad api calls ([e99cff6](e99cff6)) * set field missing where buildid goes, fix query to use append ([6af7695](6af7695)) * settings default roles not displaying ([41a3047](41a3047)) * spacing in query ([81123fa](81123fa)) * style & linting fixes ([f679523](f679523)) * styling ([4111ebc](4111ebc)) * supply platform when granting promocode ([827bc15](827bc15)) * syndicate embed not flexing on missions length ([3796d07](3796d07)) * testing new mod command organization ([8b1ba26](8b1ba26)) * too man commands triggering lfg ([fb35f72](fb35f72)) * tracker fixes ([43d91ac](43d91ac)) * tracker fixes ([07bd0fa](07bd0fa)) * tracker fixes ([f1d0dd5](f1d0dd5)) * tracker fixes ([55cf4f7](55cf4f7)) * tweets not having a grouping for different types ([2c8bc3c](2c8bc3c)) * twitter firing all cylinders all the time ([a518ce1](a518ce1)) * uncached guild owner ([25da280](25da280)) * update options accessors in calculator, sentry 2760233460 ([51f09f3](51f09f3)) * upgrade @sentry/node from 5.14.0 to 5.14.1 ([#311](#311)) ([9ed06e1](9ed06e1)) * upgrade @sentry/node from 5.14.1 to 5.14.2 ([#314](#314)) ([440dda0](440dda0)) * upgrade @sentry/node from 5.14.2 to 5.15.0 ([#315](#315)) ([588ebeb](588ebeb)) * upgrade @sentry/node from 5.15.0 to 5.15.2 ([#316](#316)) ([e2ebdd6](e2ebdd6)) * upgrade @sentry/node from 5.15.5 to 5.16.0 ([#343](#343)) ([8ddb42c](8ddb42c)) * upgrade @sentry/node from 5.16.1 to 5.17.0 ([#349](#349)) ([846ed8d](846ed8d)) * upgrade @sentry/node from 5.17.0 to 5.18.0 ([#353](#353)) ([cb3b4d6](cb3b4d6)) * upgrade @sentry/node from 5.18.0 to 5.19.0 ([#359](#359)) ([e6f1a53](e6f1a53)) * upgrade @sentry/node from 5.19.0 to 5.19.1 ([#361](#361)) ([8b8c128](8b8c128)) * upgrade @sentry/node from 5.19.1 to 5.19.2 ([#363](#363)) ([a30ddfb](a30ddfb)) * upgrade @sentry/node from 5.19.2 to 5.20.0 ([#364](#364)) ([f16bdd1](f16bdd1)) * upgrade @sentry/node from 5.20.0 to 5.20.1 ([#366](#366)) ([be8bed6](be8bed6)) * upgrade @sentry/node from 5.22.3 to 5.23.0 ([#380](#380)) ([2470afc](2470afc)) * upgrade @sentry/node from 5.23.0 to 5.24.2 ([#382](#382)) ([ae7c0d3](ae7c0d3)) * upgrade @sentry/node from 5.24.2 to 5.25.0 ([#396](#396)) ([363175d](363175d)) * upgrade @sentry/node from 5.27.0 to 5.27.1 ([#406](#406)) ([0befb7c](0befb7c)) * upgrade @sentry/node from 5.27.1 to 5.27.2 ([#407](#407)) ([480e87b](480e87b)) * upgrade @sentry/node from 5.27.2 to 5.27.3 ([#411](#411)) ([127ca4d](127ca4d)) * upgrade @sentry/node from 5.27.3 to 5.27.4 ([#412](#412)) ([5ac5fab](5ac5fab)) * upgrade @sentry/node from 5.27.4 to 5.27.6 ([#416](#416)) ([d8145b6](d8145b6)) * upgrade @sentry/node from 5.27.6 to 5.29.0 ([#422](#422)) ([9ad5fb8](9ad5fb8)) * upgrade @sentry/node from 5.29.0 to 5.29.1 ([#427](#427)) ([8907718](8907718)) * upgrade @sentry/node from 5.29.1 to 5.29.2 ([#432](#432)) ([81f862c](81f862c)) * upgrade @sentry/node from 5.29.2 to 5.30.0 ([#438](#438)) ([ef5fb39](ef5fb39)) * upgrade @sentry/node from 5.7.1 to 5.14.0 ([#305](#305)) ([b853d48](b853d48)) * upgrade @spectacles/rest from 0.5.2 to 0.6.1 ([#307](#307)) ([7c81e01](7c81e01)) * upgrade @spectacles/rest from 0.6.1 to 0.8.3 ([#318](#318)) ([ba92c30](ba92c30)) * upgrade bluebird from 3.7.1 to 3.7.2 ([#312](#312)) ([6e89312](6e89312)) * upgrade bufferutil from 4.0.1 to 4.0.2 ([#408](#408)) ([5133ca1](5133ca1)) * upgrade bufferutil from 4.0.2 to 4.0.3 ([#431](#431)) ([ad04290](ad04290)) * upgrade decache from 4.5.1 to 4.6.0 ([#335](#335)) ([4daada2](4daada2)) * upgrade discord-giveaways from 3.0.7 to 3.2.3 ([#306](#306)) ([9c5d89a](9c5d89a)) * upgrade discord.js from 12.0.2 to 12.2.0 ([#320](#320)) ([c2f66d9](c2f66d9)) * upgrade discord.js from 12.2.0 to 12.3.0 ([#370](#370)) ([3445f2b](3445f2b)) * upgrade discord.js from 12.3.1 to 12.4.0 ([#401](#401)) ([fc99210](fc99210)) * upgrade discord.js from 12.4.1 to 12.5.0 ([#415](#415)) ([c9cb0a1](c9cb0a1)) * upgrade discord.js from 12.5.0 to 12.5.1 ([#419](#419)) ([32e1810](32e1810)) * upgrade discord.js from 12.5.1 to 12.5.2 ([#449](#449)) ([87ac0c5](87ac0c5)) * upgrade moment from 2.26.0 to 2.27.0 ([#352](#352)) ([20e8026](20e8026)) * upgrade moment from 2.27.0 to 2.28.0 ([#381](#381)) ([5a62680](5a62680)) * upgrade moment from 2.28.0 to 2.29.0 ([#390](#390)) ([8031d74](8031d74)) * upgrade moment from 2.29.0 to 2.29.1 ([#397](#397)) ([fb810b2](fb810b2)) * upgrade ms from 2.1.2 to 2.1.3 ([#423](#423)) ([ff53fce](ff53fce)) * upgrade mysql2 from 2.0.0 to 2.1.0 ([#308](#308)) ([486387e](486387e)) * upgrade mysql2 from 2.2.1 to 2.2.2 ([#384](#384)) ([b6fbb09](b6fbb09)) * upgrade mysql2 from 2.2.2 to 2.2.5 ([#389](#389)) ([3cc9776](3cc9776)) * upgrade node-fetch from 2.6.0 to 2.6.1 ([#377](#377)) ([a123f88](a123f88)) * upgrade parse-duration from 0.1.1 to 0.1.2 ([#310](#310)) ([122803c](122803c)) * upgrade parse-duration from 0.1.2 to 0.3.0 ([#319](#319)) ([7b90e47](7b90e47)) * upgrade parse-duration from 0.3.1 to 0.3.2 ([#327](#327)) ([b3b0dc2](b3b0dc2)) * upgrade parse-duration from 0.4.2 to 0.4.3 ([#334](#334)) ([57d44fc](57d44fc)) * upgrade ping from 0.2.3 to 0.3.0 ([#394](#394)) ([e131382](e131382)) * upgrade ping from 0.3.0 to 0.4.0 ([#428](#428)) ([91512e4](91512e4)) * upgrade rss-feed-emitter from 3.0.0 to 3.1.2 ([08603c8](08603c8)) * upgrade rss-feed-emitter from 3.1.2 to 3.2.0 ([#365](#365)) ([11d2569](11d2569)) * upgrade rss-feed-emitter from 3.2.1 to 3.2.2 ([#369](#369)) ([c68680f](c68680f)) * upgrade topgg-autoposter from 1.1.6 to 1.1.7 ([#443](#443)) ([da6a741](da6a741)) * upgrade twitch from 3.5.6 to 3.7.1 ([#309](#309)) ([65124ed](65124ed)) * upgrade twitch from 4.0.10 to 4.0.12 ([#354](#354)) ([317d6b6](317d6b6)) * upgrade twitch from 4.0.12 to 4.1.2 ([#357](#357)) ([f7e20b4](f7e20b4)) * upgrade twitch from 4.1.2 to 4.1.3 ([#360](#360)) ([a381d09](a381d09)) * upgrade twitch from 4.2.0 to 4.2.1 ([#376](#376)) ([6fe9c66](6fe9c66)) * upgrade twitch from 4.2.1 to 4.2.2 ([#379](#379)) ([fe304c6](fe304c6)) * upgrade twitch from 4.2.2 to 4.2.3 ([#385](#385)) ([91d2c47](91d2c47)) * upgrade twitch from 4.2.3 to 4.2.4 ([#388](#388)) ([5d8b435](5d8b435)) * upgrade twitch from 4.2.4 to 4.2.5 ([#393](#393)) ([0b83882](0b83882)) * upgrade twitch from 4.2.5 to 4.2.6 ([#399](#399)) ([0288119](0288119)) * upgrade twitch from 4.2.6 to 4.2.7 ([#403](#403)) ([196cda9](196cda9)) * upgrade twitch from 4.2.7 to 4.3.0 ([#413](#413)) ([5671698](5671698)) * upgrade twitch from 4.3.0 to 4.3.1 ([#418](#418)) ([2cc0b3f](2cc0b3f)) * upgrade twitch from 4.3.1 to 4.3.5 ([#421](#421)) ([082aa0a](082aa0a)) * upgrade twitch from 4.3.5 to 4.3.6 ([#425](#425)) ([dab83ab](dab83ab)) * upgrade twitch from 4.3.6 to 4.3.7 ([#430](#430)) ([36f71a4](36f71a4)) * upgrade twitch from 4.3.7 to 4.3.8 ([#434](#434)) ([74a1661](74a1661)) * upgrade twitch from 4.3.8 to 4.4.0 ([#437](#437)) ([fa56ffb](fa56ffb)) * upgrade twitch from 4.4.0 to 4.4.1 ([#439](#439)) ([836185f](836185f)) * upgrade twitch-webhooks from 4.0.10 to 4.0.12 ([#355](#355)) ([53f13d5](53f13d5)) * upgrade twitch-webhooks from 4.1.4 to 4.2.0 ([#373](#373)) ([1888772](1888772)) * upgrade twitch-webhooks from 4.2.0 to 4.2.1 ([#375](#375)) ([5a20b22](5a20b22)) * upgrade twitch-webhooks from 4.2.1 to 4.2.2 ([#378](#378)) ([2b9fc44](2b9fc44)) * upgrade twitch-webhooks from 4.2.2 to 4.2.3 ([#386](#386)) ([73b0b7d](73b0b7d)) * upgrade twitch-webhooks from 4.2.3 to 4.2.4 ([#387](#387)) ([867388a](867388a)) * upgrade twitch-webhooks from 4.2.4 to 4.2.5 ([#392](#392)) ([fb8cbff](fb8cbff)) * upgrade twitch-webhooks from 4.2.5 to 4.2.6 ([#398](#398)) ([92ba850](92ba850)) * upgrade twitch-webhooks from 4.2.6 to 4.2.7 ([#402](#402)) ([da9c321](da9c321)) * upgrade twitch-webhooks from 4.2.7 to 4.3.0 ([#414](#414)) ([ab86137](ab86137)) * upgrade twitch-webhooks from 4.3.0 to 4.3.1 ([#417](#417)) ([1aa60c4](1aa60c4)) * upgrade twitch-webhooks from 4.3.5 to 4.3.6 ([#424](#424)) ([85c4885](85c4885)) * upgrade twitch-webhooks from 4.3.6 to 4.3.7 ([#429](#429)) ([fe95207](fe95207)) * upgrade twitch-webhooks from 4.3.7 to 4.3.8 ([#433](#433)) ([353df23](353df23)) * upgrade utf-8-validate from 5.0.2 to 5.0.3 ([#409](#409)) ([305a85f](305a85f)) * upgrade utf-8-validate from 5.0.3 to 5.0.4 ([#435](#435)) ([ff5ee33](ff5ee33)) * upgrade zlib-sync from 0.1.6 to 0.1.7 ([#350](#350)) ([257972b](257972b)) * usages for untrack using "track" instead of "untrack" ([9b01e9f](9b01e9f)) * use the right lengths for pool tables ([7d36bd5](7d36bd5)) * userinfo regex ([d589414](d589414)) * Separate notifier (#341) ([d14e0c6](d14e0c6)), closes [#341](#341) [#331](#331) [#300](#300) [#270](#270) ### Features * acolyte depart tracking, earth tracking ([947bb09](947bb09)) * add ability to force hydration from cli arg ([cbfef56](cbfef56)) * add check for leading @. closes [#426](#426) ([aa498d6](aa498d6)) * automatically allow mods to see and get into private channels ([84139d7](84139d7)) * better corgis without corggit ([75d1545](75d1545)) * cache guilds & common large queries to flatfiles ([6c4371a](6c4371a)) * cambion ([cd58ecb](cd58ecb)) * check if user has a code already ([e6b1044](e6b1044)) * Codes, Pagination for multi-result embeds ([#208](#208)) ([aa81a1c](aa81a1c)) * common captures, cc images, cc edits ([e2a48ea](e2a48ea)) * custom tracking for solaris warm/cold cycle ([f3d148a](f3d148a)) * hard disable commands globally from code ([bec524a](bec524a)) * linting, set up webhooks during tracking, add necralisk ([f287db5](f287db5)) * make fissure timestamp the end time for the fissure ([4ab5f34](4ab5f34)) * New translations en.json (Czech) ([#451](#451)) ([6605484](6605484)) * **pencil:** greenkeeper-lockfile additions for CI, cc ping setting ([#203](#203)) ([8a94ecf](8a94ecf)) * pull the most relevant option for inline weapon and wf inline searches ([b3e1159](b3e1159)) * reenable pings (wip) ([67d1815](67d1815)) * riven stats from the api ([77b1ac2](77b1ac2)) * role/channel statistics mappings, linting ([5c79a0e](5c79a0e)) * schema additions for streams and role tracking ([f275bb4](f275bb4)) * separate notifier for cycles. closes [#507](#507). closes [#506](#506) ([977d8b1](977d8b1)) * steel path embed & notifications ([85e2d19](85e2d19)) * syndicate embed alterations for bounties ([a993f54](a993f54)) * twitch notifications ([0cfa18e](0cfa18e)) * update news embed to use better fields ([3f0947e](3f0947e)) ### Reverts * Revert "Clean up some DB Calls, other tweaks (#172)" (#173) ([e98ea35](e98ea35)), closes [#172](#172) [#173](#173) * Revert "fix for undefined result" ([7865419](7865419)) * Revert "adding some alerts and notifier optimizations and customizations" ([688c386](688c386)) * Revert "add rejectunauthorized" ([e1f3155](e1f3155)) * Revert "Update Arcane.js" ([6d689a7](6d689a7)) * Revert "Update Tutorial.js" ([c7dc0ea](c7dc0ea)) * Revert "Update Tracker.js" ([674ada3](674ada3)) * Revert "Update ItemEmbeddedInline.js" ([d91f7b1](d91f7b1)) * Revert "Update Weapon.js" ([ff8c1f7](ff8c1f7)) ### BREAKING CHANGES * Notifier usage will need a new process and config * chore: decrease ctx lookup for non-bot scopes * fix: clean up fissures & arbi's are generated, move data generation into blocking part of script * task: bot working in parallel * feat: upgrade twitch notifier * refactor notifier to use notifiedIds db, clean up add build command, cleaner startup
|
🎉 This issue has been resolved in version 1.0.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Summary:
move all of the notification delivery functionality to a worker process so the main bot process doesn't have to do any of that.
The notifier will be responsible for:
I may end up rewriting some of the db code to trim what's pulled in for the database when the worker is created so that no extra "features" can creep in.
The text was updated successfully, but these errors were encountered: