fix(jobs): null check jobs for id

WFCD · Dec 15, 2020 · 70382c9 · 70382c9
1 parent 963ee32
commit 70382c9
Show file tree

Hide file tree

Showing 2 changed files with 29 additions and 19 deletions.
diff --git a/lib/SyndicateJob.js b/lib/SyndicateJob.js
@@ -151,7 +151,7 @@ class SyndicateJob extends WorldstateObject {
    * @param   {string}             deps.locale     Locale to use for translations
    */
   constructor(data, expiry, { translator, timeDate, locale }) {
-    super({ _id: { $oid: data.JobCurrentVersion ? data.JobCurrentVersion.$oid : `${data.jobType.split('/').slice(-1)[0]}${expiry.getTime()}` } }, { timeDate });
+    super({ _id: { $oid: data.JobCurrentVersion ? data.JobCurrentVersion.$oid : `${(data.jobType || '').split('/').slice(-1)[0]}${expiry.getTime()}` } }, { timeDate });
 
     /**
      * Array of strings describing rewards

diff --git a/package.json b/package.json
@@ -65,34 +65,44 @@
   "release": {
     "branch": "master"
   },
-  "eslintIgnore": [".github/**", "docs/**", "resources/**", "types/**"],
+  "eslintIgnore": [
+    ".github/**",
+    "docs/**",
+    "resources/**",
+    "types/**"
+  ],
   "eslintConfig": {
     "extends": "airbnb-base",
     "parserOptions": {
       "sourceType": "script"
     },
     "rules": {
-      "valid-jsdoc": ["error", {
-        "requireReturn": false,
-        "requireReturnDescription": false,
-        "preferType": {
-          "String": "string",
-          "Number": "number",
-          "Boolean": "boolean",
-          "Function": "function",
-          "object": "Object",
-          "date": "Date",
-          "error": "Error"
-        },
-        "prefer": {
-          "return": "returns"
+      "valid-jsdoc": [
+        "error",
+        {
+          "requireReturn": false,
+          "requireReturnDescription": false,
+          "preferType": {
+            "String": "string",
+            "Number": "number",
+            "Boolean": "boolean",
+            "Function": "function",
+            "object": "Object",
+            "date": "Date",
+            "error": "Error"
+          },
+          "prefer": {
+            "return": "returns"
+          }
         }
-      }],
+      ],
       "no-underscore-dangle": "off",
-      "strict": ["error", "safe"],
+      "strict": [
+        "error",
+        "safe"
+      ],
       "linebreak-style": "off",
       "import/no-unresolved": 0
     }
   }
-
 }