🌌 Clusterize #2749
Draft
🌌 Clusterize #2749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrharpo
added
CD 🏗️
afred
requested changes
May 3, 2024
| @@ -419,7 +419,7 @@ def playlist_order | |||
| end | |||
| def playlist_map | |||
| @playlist_map ||= begin | |||
| response = RSolr.connect(url: 'http://localhost:8983/solr/').get('select', params: | |||
| response = RSolr.connect(url: config.solr_url).get('select', params: | |||
There was a problem hiding this comment.
@mrharpo where does the config method come from here?
| # TODO: Get separate dev and test cores, and change this back to 8888. bug #1 | ||
| production: | ||
| url: http://127.0.0.1:8983/solr/blacklight-core | ||
| url: <%= ENV['SOLR_URL'] || 'http://127.0.0.1:8983/solr/' %> |
There was a problem hiding this comment.
I think Blacklight might be expecting the core name (blacklight-core) as part of the URL, isn't it?
| @@ -10,7 +10,8 @@ class Solr | |||
| def initialize | |||
| environment = ENV['RAILS_ENV'] || DEFAULT | |||
| conf = YAML.load_file(Rails.root + 'config/blacklight.yml') | |||
| @connect = RSolr.connect(url: conf[environment]['url']) | |||
| solr_url = ENV['SOLR_URL'] || conf[environment]['url'] | |||
| @connect = RSolr.connect(url: solr_url + 'blacklight-core') | |||
There was a problem hiding this comment.
(see also above comment)
Blacklight gem may be expecting the core name to be a part of the configured URL, so we may run into issues by removing it from blacklight.yml and adding it back here.
| @@ -112,7 +112,7 @@ def process_query(query) | |||
| q = QueryMaker.translate(query) | |||
| $LOG.info("Query solr for #{query}") | |||
|
|
|||
| @options[:ids] = RSolr.connect(url: 'http://localhost:8983/solr/') | |||
| @options[:ids] = RSolr.connect(url: config.solr_url) | |||
There was a problem hiding this comment.
(see other related comments)
we're leaving the core name off here, but adding it when connecting to Solr in lib/solr.rb.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clusterize
Updates for Kubernetes deployment