Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⬇️ Download MMIF #213

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

⬇️ Download MMIF #213

wants to merge 7 commits into from

Conversation

mrharpo
Copy link
Contributor

@mrharpo mrharpo commented Apr 2, 2024

Download MMIF

Splits download mmif function for reuse

  • Batches
    • Download MMIF from single batch
    • Download MMIF multiple batches
  • MMIF
    • Download single MMIF
    • Download multiple MMIF

If there is only 1 MMIF, download the file directly, instead of zipping it.

Closes #210

@mrharpo mrharpo self-assigned this Apr 2, 2024
@mrharpo mrharpo added this to the v0.5.0 Chowda 🍲 milestone Apr 2, 2024
@codecov-commenter
Copy link

codecov-commenter commented Apr 2, 2024

Codecov Report

Attention: Patch coverage is 71.42857% with 14 lines in your changes are missing coverage. Please review.

Project coverage is 66.97%. Comparing base (9925b5e) to head (22f2383).

Files Patch % Lines
chowda/utils.py 74.28% 9 Missing ⚠️
chowda/views.py 64.28% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #213      +/-   ##
==========================================
- Coverage   67.04%   66.97%   -0.07%     
==========================================
  Files          20       20              
  Lines        1050     1066      +16     
==========================================
+ Hits          704      714      +10     
- Misses        346      352       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mrharpo mrharpo added the enhancement ➕ New feature or request label Apr 2, 2024
@mrharpo mrharpo marked this pull request as ready for review April 3, 2024 17:27
@mrharpo mrharpo requested review from afred and foglabs April 3, 2024 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement ➕ New feature or request
Projects
Status: 👀 In review
Development

Successfully merging this pull request may close these issues.

Download single MMIF Dowloading all MMIF files for a batch no longer works
2 participants