Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🏎 Vite #38

Merged
merged 13 commits into from
Jun 26, 2024
Merged

🏎 Vite #38

merged 13 commits into from
Jun 26, 2024

Conversation

mrharpo
Copy link
Contributor

@mrharpo mrharpo commented Feb 1, 2024

Vite

What

Vite (French word for "quick", pronounced /vit/, like "veet")

Why

From the Remix Future docs:

Vite is a powerful, performant and extensible development environment for JavaScript projects. In order to improve and extend Remix's bundling capabilities, we now support Vite as an alternative compiler. In the future, Vite will become the default compiler for Remix.

How

This PR follows the migration guide, and gets a working version rendering!

When

It's ready to go now!

@mrharpo mrharpo added maintenance 🔧 Updates and upgrades breaking 💔 Breaking changes labels Feb 1, 2024
@foglabs
Copy link
Contributor

foglabs commented Feb 2, 2024

@mrharpo is the change from ~/foldername to ../foldername a change for vite or a preferred style?

@mrharpo
Copy link
Contributor Author

mrharpo commented Feb 2, 2024

@foglabs Vite had trouble resolving the ~/. Would definitely prefer the ~ in most cases.

I tried a few things (can't remember which), but that was the first thing that fixed it.

Base automatically changed from peter-fixes to main February 7, 2024 16:19
@mrharpo mrharpo self-assigned this Feb 7, 2024
* main: (27 commits)
  'change carousel to hero iamge'
  'carousel config'
  'carousel restyle'
  'cruft and key'
  'static page fixes'
  Better sidebar scrolling at top of page
  Moves sidebar title inline with menu icon
  Moves author bubble above menu
  Converts Sidebar menu to collapsable
  'nav spacing, series link heights and spacing, tweak body width, add body column media q for big screens'
  'breakword on body p elements'
  'remove cruft'
  'correct exhibit link in carousel'
  Fixes mobile menu
  Fixes page body margins
  Fixed position series search bar
  Fixes affiliate drawer position
  Fixes drawer menus
  Fixes font sizes and margins
  Fixes menu item spacing
  ...
@mrharpo
Copy link
Contributor Author

mrharpo commented Apr 1, 2024

Remix Vite is now stable with Remix 2.7.0 🎉

@mrharpo mrharpo marked this pull request as ready for review May 22, 2024 22:09
@mrharpo mrharpo marked this pull request as draft May 23, 2024 16:33
@mrharpo mrharpo marked this pull request as ready for review June 4, 2024 18:54
@mrharpo mrharpo requested a review from foglabs June 4, 2024 18:54
@foglabs foglabs merged commit 0a9526d into main Jun 26, 2024
2 checks passed
@foglabs foglabs deleted the vite branch June 26, 2024 19:52
@foglabs foglabs restored the vite branch June 26, 2024 19:52
@foglabs foglabs deleted the vite branch June 26, 2024 19:52
@mrharpo mrharpo restored the vite branch June 26, 2024 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking 💔 Breaking changes maintenance 🔧 Updates and upgrades
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants