Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docker compose restructure #3

Merged
merged 5 commits into from
Jun 21, 2022
Merged

Docker compose restructure #3

merged 5 commits into from
Jun 21, 2022

Conversation

mrharpo
Copy link
Contributor

@mrharpo mrharpo commented Jun 17, 2022

docker-compose restructure

After ov_wag PR#36

  • Inherits docker-compose.yml from ov_wag

front.yml

  • Adds front.yml for frontend image integration
    • OV_API_URL
      • link directly to backend container
    • volumes
      • files mounted locally
    • ports: 3000:3000

./ov

  • Migrate ./ovto match ov_wag structure
    • $COMPOSE_DEV to $COMPOSE $DEV

submodule

  • Updated ov_wag to include PR#36

@mrharpo mrharpo added the enhancement ➕ New feature or request label Jun 17, 2022
@mrharpo mrharpo requested a review from afred June 17, 2022 18:06
@mrharpo mrharpo self-assigned this Jun 17, 2022
@mrharpo mrharpo added this to the Demo milestone Jun 17, 2022
afred
afred approved these changes Jun 21, 2022
View reviewed changes
Copy link
Contributor

@afred afred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@afred afred merged commit 24a9089 into main Jun 21, 2022
@afred afred deleted the docker-compose-restructure branch June 21, 2022 20:46
This was referenced Jun 24, 2022
Merged
Merged
@mrharpo mrharpo added CI 🦾 Relating to Continuous Integration CD 🏗️ Relating to Continuous Deployment labels Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afred afred afred approved these changes

Assignees

@mrharpo mrharpo

Labels
CD 🏗️ Relating to Continuous Deployment CI 🦾 Relating to Continuous Integration enhancement ➕ New feature or request
Projects
No open projects
OV Redesign 2022
Status: ✅ Done
Milestone
v0.1.0 Demo 🏗️
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mrharpo @afred