Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-restructure docker compose #5

Merged
merged 3 commits into from
Jun 28, 2022
Merged

Re-restructure docker compose #5

merged 3 commits into from
Jun 28, 2022

Conversation

mrharpo
Copy link
Contributor

@mrharpo mrharpo commented Jun 24, 2022

Because

The config files for #3 break the docker compose build process.

From the Compose documentation:

When you use multiple configuration files, you must make sure all paths in the files are relative to the base Compose file (the first Compose file specified with -f).

Solution

Configure with 3 files:

  • docker-compose.yml
    • Barebones file
    • Just build context, with relative paths
  • ov_wag/docker-compose.yml
    • Overwrite with normal settings from ov_wag defaults
    • Contains incorrect (non-relative) paths
  • deploy.yml
    • Overwrite paths with relative links

With ov_wag PR41

@mrharpo mrharpo added the bug 🐛 Something isn't working label Jun 24, 2022
@mrharpo mrharpo requested a review from afred June 24, 2022 14:57
@mrharpo mrharpo self-assigned this Jun 24, 2022
@mrharpo mrharpo mentioned this pull request Jun 24, 2022
Merged
@mrharpo mrharpo added this to the Demo milestone Jun 27, 2022
afred
afred approved these changes Jun 28, 2022
View reviewed changes
Copy link
Contributor

@afred afred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@afred afred merged commit ed0694c into main Jun 28, 2022
@afred afred deleted the re-restructure-docker-compose branch June 28, 2022 21:57
@mrharpo mrharpo added CI 🦾 Relating to Continuous Integration CD 🏗️ Relating to Continuous Deployment labels Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afred afred afred approved these changes

Assignees

@mrharpo mrharpo

Labels
bug 🐛 Something isn't working CD 🏗️ Relating to Continuous Deployment CI 🦾 Relating to Continuous Integration
Projects
No open projects
OV Redesign 2022
Status: ✅ Done
Milestone
v0.1.0 Demo 🏗️
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mrharpo @afred