Spec header parsing for aggregate debug reporting #1292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apasel422
previously requested changes
May 21, 2024
apasel422
previously requested changes
May 21, 2024
apasel422
previously requested changes
May 22, 2024
apasel422
reviewed
May 23, 2024
apasel422
approved these changes
May 23, 2024
linnan-github
force-pushed
the
adrHeader
branch
2 times, most recently
from
f7b974f
to
9a69567
Compare
Co-authored-by: Andrew Paseltiner <apaseltiner@google.com>
Co-authored-by: Andrew Paseltiner <apaseltiner@google.com>
Co-authored-by: Andrew Paseltiner <apaseltiner@google.com>
Co-authored-by: Andrew Paseltiner <apaseltiner@google.com>
apasel422
approved these changes
May 31, 2024
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Jun 3, 2024
WICG/attribution-reporting-api#1292 A follow up CL will hook up with source and trigger registration. Note that two new debug data types are added, but as they are not supported for verbose debug reports, we don't have to update enums.xml. Bug: 343870498 Change-Id: I8400b9609c03a77ea6c78b5bbab1ed99078e0996 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5564166 Reviewed-by: John Delaney <johnidel@chromium.org> Reviewed-by: danakj <danakj@chromium.org> Reviewed-by: Andrew Paseltiner <apaseltiner@chromium.org> Commit-Queue: Nan Lin <linnan@chromium.org> Cr-Commit-Position: refs/heads/main@{#1309487}
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Jun 3, 2024
registration WICG/attribution-reporting-api#1292 Change-Id: Iea9e8552ce7e9753906ba2fb960f3096e7f26e5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5555203 Reviewed-by: Andrew Paseltiner <apaseltiner@chromium.org> Commit-Queue: Nan Lin <linnan@chromium.org> Reviewed-by: Joe Mason <joenotcharles@google.com> Cr-Commit-Position: refs/heads/main@{#1309550}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1289
Preview | Diff