Remove privacy_budget_key #471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnivdel
approved these changes
Jun 3, 2022
johnivdel
reviewed
Jun 3, 2022
There was a problem hiding this comment.
I think you are missing the removal of a refernce to this in https://github.com/WICG/attribution-reporting-api/blob/main/AGGREGATE.md#data-processing-through-a-secure-aggregation-service
|
Thanks, done. |
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Jun 7, 2022
What: This CL removes the privacy_budget_key from aggregatable reports It also moves the attribution_destination and the source_registration_time into shared_info. Why: See associated PR: WICG/attribution-reporting-api#471 How: Moving attribution_destination and source_registration_time into shared_info means that shared_info is no longer API-agnostic, since these fields are specific to the Attribution Reporting API. To ensure we don't introduce a layering violation, SharedInfo is extended to support arbitrary fields from callers. The aggregation service tool is also extended to support arbitrary shared data fields. Note: This change makes the "report" output of the attribution simulator completely empty. A follow-up CL should adjust the simulator to output a portion of the shared_info field. Bug: 1277514 Change-Id: I3d4ae87aa342424e6d2ab7878f8022675d740aec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3689018 Reviewed-by: Nan Lin <linnan@chromium.org> Reviewed-by: Alex Turner <alexmt@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/main@{#1011470}
hostirosti
added a commit
to hostirosti/trusted-execution-aggregation-service
that referenced
this pull request
Jun 27, 2022
The Attribution Reporting API aggregatable reports format changed with [WICG/attribution-reporting-api#471 rolled out in Chrome 104 (currently available on the Beta channel). This change adds a note that the new format of the aggregatable reports is currently not supported by the implementation of the aggregation service (both `LocalTestingTool` and deployment on AWS).
hostirosti
added a commit
to privacysandbox/aggregation-service
that referenced
this pull request
Jun 27, 2022
The Attribution Reporting API aggregatable reports format changed with [WICG/attribution-reporting-api#471 rolled out in Chrome 104 (currently available on the Beta channel). This change adds a note that the new format of the aggregatable reports is currently not supported by the implementation of the aggregation service (both `LocalTestingTool` and deployment on AWS).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #365 and simplifies the aggregatable report.