Allow usage of resizeTo() and resizeBy() APIs via user gesture #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Oct 27, 2023
Currently, we don't allow picture-in-picture windows to use the resizeTo() and resizeBy() APIs to prevent abuse. This CL adds a user gesture requirement to those APIs for document picture-in-picture windows to allow them to use those APIs while limiting the potential for abuse. Specification: WICG/document-picture-in-picture#104 Bug: 1354325 Change-Id: I6eabb2e9b8923ec1fc395cb44e3cc00ad674f5da
This was referenced Oct 31, 2023
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Nov 17, 2023
Currently, we don't allow picture-in-picture windows to use the resizeTo() and resizeBy() APIs to prevent abuse. This CL adds a user gesture requirement to those APIs for document picture-in-picture windows to allow them to use those APIs while limiting the potential for abuse. Specification: WICG/document-picture-in-picture#104 Bug: 1354325 Change-Id: I6eabb2e9b8923ec1fc395cb44e3cc00ad674f5da
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Nov 20, 2023
Currently, we don't allow picture-in-picture windows to use the resizeTo() and resizeBy() APIs to prevent abuse. This CL adds a user gesture requirement to those APIs for document picture-in-picture windows to allow them to use those APIs while limiting the potential for abuse. Specification: WICG/document-picture-in-picture#104 Bug: 1354325 Change-Id: I6eabb2e9b8923ec1fc395cb44e3cc00ad674f5da
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Nov 29, 2023
Currently, we don't allow picture-in-picture windows to use the resizeTo() and resizeBy() APIs to prevent abuse. This CL adds a user gesture requirement to those APIs for document picture-in-picture windows to allow them to use those APIs while limiting the potential for abuse. Specification: WICG/document-picture-in-picture#104 Bug: 1354325 Change-Id: I6eabb2e9b8923ec1fc395cb44e3cc00ad674f5da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4980802 Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Fr <beaufort.francois@gmail.com> Reviewed-by: Frank Liberato <liberato@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/main@{#1230725}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Nov 29, 2023
Currently, we don't allow picture-in-picture windows to use the resizeTo() and resizeBy() APIs to prevent abuse. This CL adds a user gesture requirement to those APIs for document picture-in-picture windows to allow them to use those APIs while limiting the potential for abuse. Specification: WICG/document-picture-in-picture#104 Bug: 1354325 Change-Id: I6eabb2e9b8923ec1fc395cb44e3cc00ad674f5da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4980802 Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Fr <beaufort.francois@gmail.com> Reviewed-by: Frank Liberato <liberato@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/main@{#1230725}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Nov 30, 2023
Currently, we don't allow picture-in-picture windows to use the resizeTo() and resizeBy() APIs to prevent abuse. This CL adds a user gesture requirement to those APIs for document picture-in-picture windows to allow them to use those APIs while limiting the potential for abuse. Specification: WICG/document-picture-in-picture#104 Bug: 1354325 Change-Id: I6eabb2e9b8923ec1fc395cb44e3cc00ad674f5da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4980802 Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Fr <beaufort.francois@gmail.com> Reviewed-by: Frank Liberato <liberato@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/main@{#1230725}
cdesouza-chromium
added a commit
to brave/brave-core
that referenced
this pull request
Dec 1, 2023
The override for `LocalDOMWindow::resizeTo` was broken by the addition of an extra exception state argument. This argument is of no consequence to the override itself. This change adjusts the override to pass the exception state along. Chromium change: https://chromium.googlesource.com/chromium/src/+/f17e2aa8de58031d15efa2c0f6de1e0fb48d0b09 commit f17e2aa8de58031d15efa2c0f6de1e0fb48d0b09 Author: Tommy Steimel <steimel@chromium.org> Date: Wed Nov 29 17:32:08 2023 +0000 [document pip] Allow resizeTo()/resizeBy() via user gesture Currently, we don't allow picture-in-picture windows to use the resizeTo() and resizeBy() APIs to prevent abuse. This CL adds a user gesture requirement to those APIs for document picture-in-picture windows to allow them to use those APIs while limiting the potential for abuse. Specification: WICG/document-picture-in-picture#104 Bug: 1354325
cdesouza-chromium
added a commit
to brave/brave-core
that referenced
this pull request
Dec 1, 2023
The override for `LocalDOMWindow::resizeTo` was broken by the addition of an extra exception state argument. This argument is of no consequence to the override itself. This change adjusts the override to pass the exception state along. Chromium change: https://chromium.googlesource.com/chromium/src/+/f17e2aa8de58031d15efa2c0f6de1e0fb48d0b09 commit f17e2aa8de58031d15efa2c0f6de1e0fb48d0b09 Author: Tommy Steimel <steimel@chromium.org> Date: Wed Nov 29 17:32:08 2023 +0000 [document pip] Allow resizeTo()/resizeBy() via user gesture Currently, we don't allow picture-in-picture windows to use the resizeTo() and resizeBy() APIs to prevent abuse. This CL adds a user gesture requirement to those APIs for document picture-in-picture windows to allow them to use those APIs while limiting the potential for abuse. Specification: WICG/document-picture-in-picture#104 Bug: 1354325
cdesouza-chromium
added a commit
to brave/brave-core
that referenced
this pull request
Dec 1, 2023
The override for `LocalDOMWindow::resizeTo` was broken by the addition of an extra exception state argument. This argument is of no consequence to the override itself. This change adjusts the override to pass the exception state along. Chromium change: https://chromium.googlesource.com/chromium/src/+/f17e2aa8de58031d15efa2c0f6de1e0fb48d0b09 commit f17e2aa8de58031d15efa2c0f6de1e0fb48d0b09 Author: Tommy Steimel <steimel@chromium.org> Date: Wed Nov 29 17:32:08 2023 +0000 [document pip] Allow resizeTo()/resizeBy() via user gesture Currently, we don't allow picture-in-picture windows to use the resizeTo() and resizeBy() APIs to prevent abuse. This CL adds a user gesture requirement to those APIs for document picture-in-picture windows to allow them to use those APIs while limiting the potential for abuse. Specification: WICG/document-picture-in-picture#104 Bug: 1354325
cdesouza-chromium
added a commit
to brave/brave-core
that referenced
this pull request
Dec 4, 2023
The override for `LocalDOMWindow::resizeTo` was broken by the addition of an extra exception state argument. This argument is of no consequence to the override itself. This change adjusts the override to pass the exception state along. Chromium change: https://chromium.googlesource.com/chromium/src/+/f17e2aa8de58031d15efa2c0f6de1e0fb48d0b09 commit f17e2aa8de58031d15efa2c0f6de1e0fb48d0b09 Author: Tommy Steimel <steimel@chromium.org> Date: Wed Nov 29 17:32:08 2023 +0000 [document pip] Allow resizeTo()/resizeBy() via user gesture Currently, we don't allow picture-in-picture windows to use the resizeTo() and resizeBy() APIs to prevent abuse. This CL adds a user gesture requirement to those APIs for document picture-in-picture windows to allow them to use those APIs while limiting the potential for abuse. Specification: WICG/document-picture-in-picture#104 Bug: 1354325
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Dec 4, 2023
…() via user gesture, a=testonly Automatic update from web-platform-tests [document pip] Allow resizeTo()/resizeBy() via user gesture Currently, we don't allow picture-in-picture windows to use the resizeTo() and resizeBy() APIs to prevent abuse. This CL adds a user gesture requirement to those APIs for document picture-in-picture windows to allow them to use those APIs while limiting the potential for abuse. Specification: WICG/document-picture-in-picture#104 Bug: 1354325 Change-Id: I6eabb2e9b8923ec1fc395cb44e3cc00ad674f5da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4980802 Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Fr <beaufort.francois@gmail.com> Reviewed-by: Frank Liberato <liberato@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/main@{#1230725} -- wpt-commits: 7007ee235ed368079546dd0a8ef45a7dfa88305a wpt-pr: 42797
jamienicol
pushed a commit
to jamienicol/gecko
that referenced
this pull request
Dec 5, 2023
…() via user gesture, a=testonly Automatic update from web-platform-tests [document pip] Allow resizeTo()/resizeBy() via user gesture Currently, we don't allow picture-in-picture windows to use the resizeTo() and resizeBy() APIs to prevent abuse. This CL adds a user gesture requirement to those APIs for document picture-in-picture windows to allow them to use those APIs while limiting the potential for abuse. Specification: WICG/document-picture-in-picture#104 Bug: 1354325 Change-Id: I6eabb2e9b8923ec1fc395cb44e3cc00ad674f5da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4980802 Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Fr <beaufort.francois@gmail.com> Reviewed-by: Frank Liberato <liberato@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/main@{#1230725} -- wpt-commits: 7007ee235ed368079546dd0a8ef45a7dfa88305a wpt-pr: 42797
cdesouza-chromium
added a commit
to brave/brave-core
that referenced
this pull request
Dec 6, 2023
The override for `LocalDOMWindow::resizeTo` was broken by the addition of an extra exception state argument. This argument is of no consequence to the override itself. This change adjusts the override to pass the exception state along. Chromium change: https://chromium.googlesource.com/chromium/src/+/f17e2aa8de58031d15efa2c0f6de1e0fb48d0b09 commit f17e2aa8de58031d15efa2c0f6de1e0fb48d0b09 Author: Tommy Steimel <steimel@chromium.org> Date: Wed Nov 29 17:32:08 2023 +0000 [document pip] Allow resizeTo()/resizeBy() via user gesture Currently, we don't allow picture-in-picture windows to use the resizeTo() and resizeBy() APIs to prevent abuse. This CL adds a user gesture requirement to those APIs for document picture-in-picture windows to allow them to use those APIs while limiting the potential for abuse. Specification: WICG/document-picture-in-picture#104 Bug: 1354325
cdesouza-chromium
added a commit
to brave/brave-core
that referenced
this pull request
Dec 7, 2023
The override for `LocalDOMWindow::resizeTo` was broken by the addition of an extra exception state argument. This argument is of no consequence to the override itself. This change adjusts the override to pass the exception state along. Chromium change: https://chromium.googlesource.com/chromium/src/+/f17e2aa8de58031d15efa2c0f6de1e0fb48d0b09 commit f17e2aa8de58031d15efa2c0f6de1e0fb48d0b09 Author: Tommy Steimel <steimel@chromium.org> Date: Wed Nov 29 17:32:08 2023 +0000 [document pip] Allow resizeTo()/resizeBy() via user gesture Currently, we don't allow picture-in-picture windows to use the resizeTo() and resizeBy() APIs to prevent abuse. This CL adds a user gesture requirement to those APIs for document picture-in-picture windows to allow them to use those APIs while limiting the potential for abuse. Specification: WICG/document-picture-in-picture#104 Bug: 1354325
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Dec 7, 2023
…() via user gesture, a=testonly Automatic update from web-platform-tests [document pip] Allow resizeTo()/resizeBy() via user gesture Currently, we don't allow picture-in-picture windows to use the resizeTo() and resizeBy() APIs to prevent abuse. This CL adds a user gesture requirement to those APIs for document picture-in-picture windows to allow them to use those APIs while limiting the potential for abuse. Specification: WICG/document-picture-in-picture#104 Bug: 1354325 Change-Id: I6eabb2e9b8923ec1fc395cb44e3cc00ad674f5da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4980802 Reviewed-by: Daniel Cheng <dchengchromium.org> Reviewed-by: Fr <beaufort.francoisgmail.com> Reviewed-by: Frank Liberato <liberatochromium.org> Reviewed-by: Scott Violet <skychromium.org> Commit-Queue: Tommy Steimel <steimelchromium.org> Cr-Commit-Position: refs/heads/main{#1230725} -- wpt-commits: 7007ee235ed368079546dd0a8ef45a7dfa88305a wpt-pr: 42797 UltraBlame original commit: 224ecf406e0698fdabef03cb95b70595b5657bb6
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Dec 7, 2023
…() via user gesture, a=testonly Automatic update from web-platform-tests [document pip] Allow resizeTo()/resizeBy() via user gesture Currently, we don't allow picture-in-picture windows to use the resizeTo() and resizeBy() APIs to prevent abuse. This CL adds a user gesture requirement to those APIs for document picture-in-picture windows to allow them to use those APIs while limiting the potential for abuse. Specification: WICG/document-picture-in-picture#104 Bug: 1354325 Change-Id: I6eabb2e9b8923ec1fc395cb44e3cc00ad674f5da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4980802 Reviewed-by: Daniel Cheng <dchengchromium.org> Reviewed-by: Fr <beaufort.francoisgmail.com> Reviewed-by: Frank Liberato <liberatochromium.org> Reviewed-by: Scott Violet <skychromium.org> Commit-Queue: Tommy Steimel <steimelchromium.org> Cr-Commit-Position: refs/heads/main{#1230725} -- wpt-commits: 7007ee235ed368079546dd0a8ef45a7dfa88305a wpt-pr: 42797 UltraBlame original commit: 224ecf406e0698fdabef03cb95b70595b5657bb6
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Dec 7, 2023
…() via user gesture, a=testonly Automatic update from web-platform-tests [document pip] Allow resizeTo()/resizeBy() via user gesture Currently, we don't allow picture-in-picture windows to use the resizeTo() and resizeBy() APIs to prevent abuse. This CL adds a user gesture requirement to those APIs for document picture-in-picture windows to allow them to use those APIs while limiting the potential for abuse. Specification: WICG/document-picture-in-picture#104 Bug: 1354325 Change-Id: I6eabb2e9b8923ec1fc395cb44e3cc00ad674f5da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4980802 Reviewed-by: Daniel Cheng <dchengchromium.org> Reviewed-by: Fr <beaufort.francoisgmail.com> Reviewed-by: Frank Liberato <liberatochromium.org> Reviewed-by: Scott Violet <skychromium.org> Commit-Queue: Tommy Steimel <steimelchromium.org> Cr-Commit-Position: refs/heads/main{#1230725} -- wpt-commits: 7007ee235ed368079546dd0a8ef45a7dfa88305a wpt-pr: 42797 UltraBlame original commit: 224ecf406e0698fdabef03cb95b70595b5657bb6
cdesouza-chromium
added a commit
to brave/brave-core
that referenced
this pull request
Dec 8, 2023
The override for `LocalDOMWindow::resizeTo` was broken by the addition of an extra exception state argument. This argument is of no consequence to the override itself. This change adjusts the override to pass the exception state along. Chromium change: https://chromium.googlesource.com/chromium/src/+/f17e2aa8de58031d15efa2c0f6de1e0fb48d0b09 commit f17e2aa8de58031d15efa2c0f6de1e0fb48d0b09 Author: Tommy Steimel <steimel@chromium.org> Date: Wed Nov 29 17:32:08 2023 +0000 [document pip] Allow resizeTo()/resizeBy() via user gesture Currently, we don't allow picture-in-picture windows to use the resizeTo() and resizeBy() APIs to prevent abuse. This CL adds a user gesture requirement to those APIs for document picture-in-picture windows to allow them to use those APIs while limiting the potential for abuse. Specification: WICG/document-picture-in-picture#104 Bug: 1354325
cdesouza-chromium
added a commit
to brave/brave-core
that referenced
this pull request
Dec 11, 2023
The override for `LocalDOMWindow::resizeTo` was broken by the addition of an extra exception state argument. This argument is of no consequence to the override itself. This change adjusts the override to pass the exception state along. Chromium change: https://chromium.googlesource.com/chromium/src/+/f17e2aa8de58031d15efa2c0f6de1e0fb48d0b09 commit f17e2aa8de58031d15efa2c0f6de1e0fb48d0b09 Author: Tommy Steimel <steimel@chromium.org> Date: Wed Nov 29 17:32:08 2023 +0000 [document pip] Allow resizeTo()/resizeBy() via user gesture Currently, we don't allow picture-in-picture windows to use the resizeTo() and resizeBy() APIs to prevent abuse. This CL adds a user gesture requirement to those APIs for document picture-in-picture windows to allow them to use those APIs while limiting the potential for abuse. Specification: WICG/document-picture-in-picture#104 Bug: 1354325
cdesouza-chromium
added a commit
to brave/brave-core
that referenced
this pull request
Dec 12, 2023
The override for `LocalDOMWindow::resizeTo` was broken by the addition of an extra exception state argument. This argument is of no consequence to the override itself. This change adjusts the override to pass the exception state along. Chromium change: https://chromium.googlesource.com/chromium/src/+/f17e2aa8de58031d15efa2c0f6de1e0fb48d0b09 commit f17e2aa8de58031d15efa2c0f6de1e0fb48d0b09 Author: Tommy Steimel <steimel@chromium.org> Date: Wed Nov 29 17:32:08 2023 +0000 [document pip] Allow resizeTo()/resizeBy() via user gesture Currently, we don't allow picture-in-picture windows to use the resizeTo() and resizeBy() APIs to prevent abuse. This CL adds a user gesture requirement to those APIs for document picture-in-picture windows to allow them to use those APIs while limiting the potential for abuse. Specification: WICG/document-picture-in-picture#104 Bug: 1354325
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Dec 13, 2023
…() via user gesture, a=testonly Automatic update from web-platform-tests [document pip] Allow resizeTo()/resizeBy() via user gesture Currently, we don't allow picture-in-picture windows to use the resizeTo() and resizeBy() APIs to prevent abuse. This CL adds a user gesture requirement to those APIs for document picture-in-picture windows to allow them to use those APIs while limiting the potential for abuse. Specification: WICG/document-picture-in-picture#104 Bug: 1354325 Change-Id: I6eabb2e9b8923ec1fc395cb44e3cc00ad674f5da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4980802 Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Fr <beaufort.francois@gmail.com> Reviewed-by: Frank Liberato <liberato@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/main@{#1230725} -- wpt-commits: 7007ee235ed368079546dd0a8ef45a7dfa88305a wpt-pr: 42797
cdesouza-chromium
added a commit
to brave/brave-core
that referenced
this pull request
Dec 13, 2023
The override for `LocalDOMWindow::resizeTo` was broken by the addition of an extra exception state argument. This argument is of no consequence to the override itself. This change adjusts the override to pass the exception state along. Chromium change: https://chromium.googlesource.com/chromium/src/+/f17e2aa8de58031d15efa2c0f6de1e0fb48d0b09 commit f17e2aa8de58031d15efa2c0f6de1e0fb48d0b09 Author: Tommy Steimel <steimel@chromium.org> Date: Wed Nov 29 17:32:08 2023 +0000 [document pip] Allow resizeTo()/resizeBy() via user gesture Currently, we don't allow picture-in-picture windows to use the resizeTo() and resizeBy() APIs to prevent abuse. This CL adds a user gesture requirement to those APIs for document picture-in-picture windows to allow them to use those APIs while limiting the potential for abuse. Specification: WICG/document-picture-in-picture#104 Bug: 1354325
cdesouza-chromium
added a commit
to brave/brave-core
that referenced
this pull request
Dec 13, 2023
The override for `LocalDOMWindow::resizeTo` was broken by the addition of an extra exception state argument. This argument is of no consequence to the override itself. This change adjusts the override to pass the exception state along. Chromium change: https://chromium.googlesource.com/chromium/src/+/f17e2aa8de58031d15efa2c0f6de1e0fb48d0b09 commit f17e2aa8de58031d15efa2c0f6de1e0fb48d0b09 Author: Tommy Steimel <steimel@chromium.org> Date: Wed Nov 29 17:32:08 2023 +0000 [document pip] Allow resizeTo()/resizeBy() via user gesture Currently, we don't allow picture-in-picture windows to use the resizeTo() and resizeBy() APIs to prevent abuse. This CL adds a user gesture requirement to those APIs for document picture-in-picture windows to allow them to use those APIs while limiting the potential for abuse. Specification: WICG/document-picture-in-picture#104 Bug: 1354325
cdesouza-chromium
added a commit
to brave/brave-core
that referenced
this pull request
Dec 13, 2023
The override for `LocalDOMWindow::resizeTo` was broken by the addition of an extra exception state argument. This argument is of no consequence to the override itself. This change adjusts the override to pass the exception state along. Chromium change: https://chromium.googlesource.com/chromium/src/+/f17e2aa8de58031d15efa2c0f6de1e0fb48d0b09 commit f17e2aa8de58031d15efa2c0f6de1e0fb48d0b09 Author: Tommy Steimel <steimel@chromium.org> Date: Wed Nov 29 17:32:08 2023 +0000 [document pip] Allow resizeTo()/resizeBy() via user gesture Currently, we don't allow picture-in-picture windows to use the resizeTo() and resizeBy() APIs to prevent abuse. This CL adds a user gesture requirement to those APIs for document picture-in-picture windows to allow them to use those APIs while limiting the potential for abuse. Specification: WICG/document-picture-in-picture#104 Bug: 1354325
cdesouza-chromium
added a commit
to brave/brave-core
that referenced
this pull request
Dec 14, 2023
The override for `LocalDOMWindow::resizeTo` was broken by the addition of an extra exception state argument. This argument is of no consequence to the override itself. This change adjusts the override to pass the exception state along. Chromium change: https://chromium.googlesource.com/chromium/src/+/f17e2aa8de58031d15efa2c0f6de1e0fb48d0b09 commit f17e2aa8de58031d15efa2c0f6de1e0fb48d0b09 Author: Tommy Steimel <steimel@chromium.org> Date: Wed Nov 29 17:32:08 2023 +0000 [document pip] Allow resizeTo()/resizeBy() via user gesture Currently, we don't allow picture-in-picture windows to use the resizeTo() and resizeBy() APIs to prevent abuse. This CL adds a user gesture requirement to those APIs for document picture-in-picture windows to allow them to use those APIs while limiting the potential for abuse. Specification: WICG/document-picture-in-picture#104 Bug: 1354325
cdesouza-chromium
added a commit
to brave/brave-core
that referenced
this pull request
Dec 15, 2023
The override for `LocalDOMWindow::resizeTo` was broken by the addition of an extra exception state argument. This argument is of no consequence to the override itself. This change adjusts the override to pass the exception state along. Chromium change: https://chromium.googlesource.com/chromium/src/+/f17e2aa8de58031d15efa2c0f6de1e0fb48d0b09 commit f17e2aa8de58031d15efa2c0f6de1e0fb48d0b09 Author: Tommy Steimel <steimel@chromium.org> Date: Wed Nov 29 17:32:08 2023 +0000 [document pip] Allow resizeTo()/resizeBy() via user gesture Currently, we don't allow picture-in-picture windows to use the resizeTo() and resizeBy() APIs to prevent abuse. This CL adds a user gesture requirement to those APIs for document picture-in-picture windows to allow them to use those APIs while limiting the potential for abuse. Specification: WICG/document-picture-in-picture#104 Bug: 1354325
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Dec 16, 2023
…() via user gesture, a=testonly Automatic update from web-platform-tests [document pip] Allow resizeTo()/resizeBy() via user gesture Currently, we don't allow picture-in-picture windows to use the resizeTo() and resizeBy() APIs to prevent abuse. This CL adds a user gesture requirement to those APIs for document picture-in-picture windows to allow them to use those APIs while limiting the potential for abuse. Specification: WICG/document-picture-in-picture#104 Bug: 1354325 Change-Id: I6eabb2e9b8923ec1fc395cb44e3cc00ad674f5da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4980802 Reviewed-by: Daniel Cheng <dchengchromium.org> Reviewed-by: Fr <beaufort.francoisgmail.com> Reviewed-by: Frank Liberato <liberatochromium.org> Reviewed-by: Scott Violet <skychromium.org> Commit-Queue: Tommy Steimel <steimelchromium.org> Cr-Commit-Position: refs/heads/main{#1230725} -- wpt-commits: 7007ee235ed368079546dd0a8ef45a7dfa88305a wpt-pr: 42797 UltraBlame original commit: 0183a1227e3704d97b5fec41d83560afbbbd7c61
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Dec 16, 2023
…() via user gesture, a=testonly Automatic update from web-platform-tests [document pip] Allow resizeTo()/resizeBy() via user gesture Currently, we don't allow picture-in-picture windows to use the resizeTo() and resizeBy() APIs to prevent abuse. This CL adds a user gesture requirement to those APIs for document picture-in-picture windows to allow them to use those APIs while limiting the potential for abuse. Specification: WICG/document-picture-in-picture#104 Bug: 1354325 Change-Id: I6eabb2e9b8923ec1fc395cb44e3cc00ad674f5da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4980802 Reviewed-by: Daniel Cheng <dchengchromium.org> Reviewed-by: Fr <beaufort.francoisgmail.com> Reviewed-by: Frank Liberato <liberatochromium.org> Reviewed-by: Scott Violet <skychromium.org> Commit-Queue: Tommy Steimel <steimelchromium.org> Cr-Commit-Position: refs/heads/main{#1230725} -- wpt-commits: 7007ee235ed368079546dd0a8ef45a7dfa88305a wpt-pr: 42797 UltraBlame original commit: 0183a1227e3704d97b5fec41d83560afbbbd7c61
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Dec 16, 2023
…() via user gesture, a=testonly Automatic update from web-platform-tests [document pip] Allow resizeTo()/resizeBy() via user gesture Currently, we don't allow picture-in-picture windows to use the resizeTo() and resizeBy() APIs to prevent abuse. This CL adds a user gesture requirement to those APIs for document picture-in-picture windows to allow them to use those APIs while limiting the potential for abuse. Specification: WICG/document-picture-in-picture#104 Bug: 1354325 Change-Id: I6eabb2e9b8923ec1fc395cb44e3cc00ad674f5da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4980802 Reviewed-by: Daniel Cheng <dchengchromium.org> Reviewed-by: Fr <beaufort.francoisgmail.com> Reviewed-by: Frank Liberato <liberatochromium.org> Reviewed-by: Scott Violet <skychromium.org> Commit-Queue: Tommy Steimel <steimelchromium.org> Cr-Commit-Position: refs/heads/main{#1230725} -- wpt-commits: 7007ee235ed368079546dd0a8ef45a7dfa88305a wpt-pr: 42797 UltraBlame original commit: 0183a1227e3704d97b5fec41d83560afbbbd7c61
cdesouza-chromium
added a commit
to brave/brave-core
that referenced
this pull request
Dec 18, 2023
The override for `LocalDOMWindow::resizeTo` was broken by the addition of an extra exception state argument. This argument is of no consequence to the override itself. This change adjusts the override to pass the exception state along. Chromium change: https://chromium.googlesource.com/chromium/src/+/f17e2aa8de58031d15efa2c0f6de1e0fb48d0b09 commit f17e2aa8de58031d15efa2c0f6de1e0fb48d0b09 Author: Tommy Steimel <steimel@chromium.org> Date: Wed Nov 29 17:32:08 2023 +0000 [document pip] Allow resizeTo()/resizeBy() via user gesture Currently, we don't allow picture-in-picture windows to use the resizeTo() and resizeBy() APIs to prevent abuse. This CL adds a user gesture requirement to those APIs for document picture-in-picture windows to allow them to use those APIs while limiting the potential for abuse. Specification: WICG/document-picture-in-picture#104 Bug: 1354325
cdesouza-chromium
added a commit
to brave/brave-core
that referenced
this pull request
Dec 19, 2023
The override for `LocalDOMWindow::resizeTo` was broken by the addition of an extra exception state argument. This argument is of no consequence to the override itself. This change adjusts the override to pass the exception state along. Chromium change: https://chromium.googlesource.com/chromium/src/+/f17e2aa8de58031d15efa2c0f6de1e0fb48d0b09 commit f17e2aa8de58031d15efa2c0f6de1e0fb48d0b09 Author: Tommy Steimel <steimel@chromium.org> Date: Wed Nov 29 17:32:08 2023 +0000 [document pip] Allow resizeTo()/resizeBy() via user gesture Currently, we don't allow picture-in-picture windows to use the resizeTo() and resizeBy() APIs to prevent abuse. This CL adds a user gesture requirement to those APIs for document picture-in-picture windows to allow them to use those APIs while limiting the potential for abuse. Specification: WICG/document-picture-in-picture#104 Bug: 1354325
cdesouza-chromium
added a commit
to brave/brave-core
that referenced
this pull request
Dec 20, 2023
The override for `LocalDOMWindow::resizeTo` was broken by the addition of an extra exception state argument. This argument is of no consequence to the override itself. This change adjusts the override to pass the exception state along. Chromium change: https://chromium.googlesource.com/chromium/src/+/f17e2aa8de58031d15efa2c0f6de1e0fb48d0b09 commit f17e2aa8de58031d15efa2c0f6de1e0fb48d0b09 Author: Tommy Steimel <steimel@chromium.org> Date: Wed Nov 29 17:32:08 2023 +0000 [document pip] Allow resizeTo()/resizeBy() via user gesture Currently, we don't allow picture-in-picture windows to use the resizeTo() and resizeBy() APIs to prevent abuse. This CL adds a user gesture requirement to those APIs for document picture-in-picture windows to allow them to use those APIs while limiting the potential for abuse. Specification: WICG/document-picture-in-picture#104 Bug: 1354325
cdesouza-chromium
added a commit
to brave/brave-core
that referenced
this pull request
Dec 21, 2023
The override for `LocalDOMWindow::resizeTo` was broken by the addition of an extra exception state argument. This argument is of no consequence to the override itself. This change adjusts the override to pass the exception state along. Chromium change: https://chromium.googlesource.com/chromium/src/+/f17e2aa8de58031d15efa2c0f6de1e0fb48d0b09 commit f17e2aa8de58031d15efa2c0f6de1e0fb48d0b09 Author: Tommy Steimel <steimel@chromium.org> Date: Wed Nov 29 17:32:08 2023 +0000 [document pip] Allow resizeTo()/resizeBy() via user gesture Currently, we don't allow picture-in-picture windows to use the resizeTo() and resizeBy() APIs to prevent abuse. This CL adds a user gesture requirement to those APIs for document picture-in-picture windows to allow them to use those APIs while limiting the potential for abuse. Specification: WICG/document-picture-in-picture#104 Bug: 1354325
cdesouza-chromium
added a commit
to brave/brave-core
that referenced
this pull request
Dec 22, 2023
The override for `LocalDOMWindow::resizeTo` was broken by the addition of an extra exception state argument. This argument is of no consequence to the override itself. This change adjusts the override to pass the exception state along. Chromium change: https://chromium.googlesource.com/chromium/src/+/f17e2aa8de58031d15efa2c0f6de1e0fb48d0b09 commit f17e2aa8de58031d15efa2c0f6de1e0fb48d0b09 Author: Tommy Steimel <steimel@chromium.org> Date: Wed Nov 29 17:32:08 2023 +0000 [document pip] Allow resizeTo()/resizeBy() via user gesture Currently, we don't allow picture-in-picture windows to use the resizeTo() and resizeBy() APIs to prevent abuse. This CL adds a user gesture requirement to those APIs for document picture-in-picture windows to allow them to use those APIs while limiting the potential for abuse. Specification: WICG/document-picture-in-picture#104 Bug: 1354325
cdesouza-chromium
added a commit
to brave/brave-core
that referenced
this pull request
Dec 25, 2023
The override for `LocalDOMWindow::resizeTo` was broken by the addition of an extra exception state argument. This argument is of no consequence to the override itself. This change adjusts the override to pass the exception state along. Chromium change: https://chromium.googlesource.com/chromium/src/+/f17e2aa8de58031d15efa2c0f6de1e0fb48d0b09 commit f17e2aa8de58031d15efa2c0f6de1e0fb48d0b09 Author: Tommy Steimel <steimel@chromium.org> Date: Wed Nov 29 17:32:08 2023 +0000 [document pip] Allow resizeTo()/resizeBy() via user gesture Currently, we don't allow picture-in-picture windows to use the resizeTo() and resizeBy() APIs to prevent abuse. This CL adds a user gesture requirement to those APIs for document picture-in-picture windows to allow them to use those APIs while limiting the potential for abuse. Specification: WICG/document-picture-in-picture#104 Bug: 1354325
cdesouza-chromium
added a commit
to brave/brave-core
that referenced
this pull request
Dec 26, 2023
The override for `LocalDOMWindow::resizeTo` was broken by the addition of an extra exception state argument. This argument is of no consequence to the override itself. This change adjusts the override to pass the exception state along. Chromium change: https://chromium.googlesource.com/chromium/src/+/f17e2aa8de58031d15efa2c0f6de1e0fb48d0b09 commit f17e2aa8de58031d15efa2c0f6de1e0fb48d0b09 Author: Tommy Steimel <steimel@chromium.org> Date: Wed Nov 29 17:32:08 2023 +0000 [document pip] Allow resizeTo()/resizeBy() via user gesture Currently, we don't allow picture-in-picture windows to use the resizeTo() and resizeBy() APIs to prevent abuse. This CL adds a user gesture requirement to those APIs for document picture-in-picture windows to allow them to use those APIs while limiting the potential for abuse. Specification: WICG/document-picture-in-picture#104 Bug: 1354325
cdesouza-chromium
added a commit
to brave/brave-core
that referenced
this pull request
Dec 27, 2023
The override for `LocalDOMWindow::resizeTo` was broken by the addition of an extra exception state argument. This argument is of no consequence to the override itself. This change adjusts the override to pass the exception state along. Chromium change: https://chromium.googlesource.com/chromium/src/+/f17e2aa8de58031d15efa2c0f6de1e0fb48d0b09 commit f17e2aa8de58031d15efa2c0f6de1e0fb48d0b09 Author: Tommy Steimel <steimel@chromium.org> Date: Wed Nov 29 17:32:08 2023 +0000 [document pip] Allow resizeTo()/resizeBy() via user gesture Currently, we don't allow picture-in-picture windows to use the resizeTo() and resizeBy() APIs to prevent abuse. This CL adds a user gesture requirement to those APIs for document picture-in-picture windows to allow them to use those APIs while limiting the potential for abuse. Specification: WICG/document-picture-in-picture#104 Bug: 1354325
cdesouza-chromium
added a commit
to brave/brave-core
that referenced
this pull request
Dec 28, 2023
The override for `LocalDOMWindow::resizeTo` was broken by the addition of an extra exception state argument. This argument is of no consequence to the override itself. This change adjusts the override to pass the exception state along. Chromium change: https://chromium.googlesource.com/chromium/src/+/f17e2aa8de58031d15efa2c0f6de1e0fb48d0b09 commit f17e2aa8de58031d15efa2c0f6de1e0fb48d0b09 Author: Tommy Steimel <steimel@chromium.org> Date: Wed Nov 29 17:32:08 2023 +0000 [document pip] Allow resizeTo()/resizeBy() via user gesture Currently, we don't allow picture-in-picture windows to use the resizeTo() and resizeBy() APIs to prevent abuse. This CL adds a user gesture requirement to those APIs for document picture-in-picture windows to allow them to use those APIs while limiting the potential for abuse. Specification: WICG/document-picture-in-picture#104 Bug: 1354325
cdesouza-chromium
added a commit
to brave/brave-core
that referenced
this pull request
Dec 29, 2023
The override for `LocalDOMWindow::resizeTo` was broken by the addition of an extra exception state argument. This argument is of no consequence to the override itself. This change adjusts the override to pass the exception state along. Chromium change: https://chromium.googlesource.com/chromium/src/+/f17e2aa8de58031d15efa2c0f6de1e0fb48d0b09 commit f17e2aa8de58031d15efa2c0f6de1e0fb48d0b09 Author: Tommy Steimel <steimel@chromium.org> Date: Wed Nov 29 17:32:08 2023 +0000 [document pip] Allow resizeTo()/resizeBy() via user gesture Currently, we don't allow picture-in-picture windows to use the resizeTo() and resizeBy() APIs to prevent abuse. This CL adds a user gesture requirement to those APIs for document picture-in-picture windows to allow them to use those APIs while limiting the potential for abuse. Specification: WICG/document-picture-in-picture#104 Bug: 1354325
cdesouza-chromium
added a commit
to brave/brave-core
that referenced
this pull request
Jan 2, 2024
The override for `LocalDOMWindow::resizeTo` was broken by the addition of an extra exception state argument. This argument is of no consequence to the override itself. This change adjusts the override to pass the exception state along. Chromium change: https://chromium.googlesource.com/chromium/src/+/f17e2aa8de58031d15efa2c0f6de1e0fb48d0b09 commit f17e2aa8de58031d15efa2c0f6de1e0fb48d0b09 Author: Tommy Steimel <steimel@chromium.org> Date: Wed Nov 29 17:32:08 2023 +0000 [document pip] Allow resizeTo()/resizeBy() via user gesture Currently, we don't allow picture-in-picture windows to use the resizeTo() and resizeBy() APIs to prevent abuse. This CL adds a user gesture requirement to those APIs for document picture-in-picture windows to allow them to use those APIs while limiting the potential for abuse. Specification: WICG/document-picture-in-picture#104 Bug: 1354325
cdesouza-chromium
added a commit
to brave/brave-core
that referenced
this pull request
Jan 3, 2024
The override for `LocalDOMWindow::resizeTo` was broken by the addition of an extra exception state argument. This argument is of no consequence to the override itself. This change adjusts the override to pass the exception state along. Chromium change: https://chromium.googlesource.com/chromium/src/+/f17e2aa8de58031d15efa2c0f6de1e0fb48d0b09 commit f17e2aa8de58031d15efa2c0f6de1e0fb48d0b09 Author: Tommy Steimel <steimel@chromium.org> Date: Wed Nov 29 17:32:08 2023 +0000 [document pip] Allow resizeTo()/resizeBy() via user gesture Currently, we don't allow picture-in-picture windows to use the resizeTo() and resizeBy() APIs to prevent abuse. This CL adds a user gesture requirement to those APIs for document picture-in-picture windows to allow them to use those APIs while limiting the potential for abuse. Specification: WICG/document-picture-in-picture#104 Bug: 1354325
cdesouza-chromium
added a commit
to brave/brave-core
that referenced
this pull request
Jan 4, 2024
The override for `LocalDOMWindow::resizeTo` was broken by the addition of an extra exception state argument. This argument is of no consequence to the override itself. This change adjusts the override to pass the exception state along. Chromium change: https://chromium.googlesource.com/chromium/src/+/f17e2aa8de58031d15efa2c0f6de1e0fb48d0b09 commit f17e2aa8de58031d15efa2c0f6de1e0fb48d0b09 Author: Tommy Steimel <steimel@chromium.org> Date: Wed Nov 29 17:32:08 2023 +0000 [document pip] Allow resizeTo()/resizeBy() via user gesture Currently, we don't allow picture-in-picture windows to use the resizeTo() and resizeBy() APIs to prevent abuse. This CL adds a user gesture requirement to those APIs for document picture-in-picture windows to allow them to use those APIs while limiting the potential for abuse. Specification: WICG/document-picture-in-picture#104 Bug: 1354325
mkarolin
pushed a commit
to brave/brave-core
that referenced
this pull request
Jan 4, 2024
The override for `LocalDOMWindow::resizeTo` was broken by the addition of an extra exception state argument. This argument is of no consequence to the override itself. This change adjusts the override to pass the exception state along. Chromium change: https://chromium.googlesource.com/chromium/src/+/f17e2aa8de58031d15efa2c0f6de1e0fb48d0b09 commit f17e2aa8de58031d15efa2c0f6de1e0fb48d0b09 Author: Tommy Steimel <steimel@chromium.org> Date: Wed Nov 29 17:32:08 2023 +0000 [document pip] Allow resizeTo()/resizeBy() via user gesture Currently, we don't allow picture-in-picture windows to use the resizeTo() and resizeBy() APIs to prevent abuse. This CL adds a user gesture requirement to those APIs for document picture-in-picture windows to allow them to use those APIs while limiting the potential for abuse. Specification: WICG/document-picture-in-picture#104 Bug: 1354325
cdesouza-chromium
added a commit
to brave/brave-core
that referenced
this pull request
Jan 4, 2024
The override for `LocalDOMWindow::resizeTo` was broken by the addition of an extra exception state argument. This argument is of no consequence to the override itself. This change adjusts the override to pass the exception state along. Chromium change: https://chromium.googlesource.com/chromium/src/+/f17e2aa8de58031d15efa2c0f6de1e0fb48d0b09 commit f17e2aa8de58031d15efa2c0f6de1e0fb48d0b09 Author: Tommy Steimel <steimel@chromium.org> Date: Wed Nov 29 17:32:08 2023 +0000 [document pip] Allow resizeTo()/resizeBy() via user gesture Currently, we don't allow picture-in-picture windows to use the resizeTo() and resizeBy() APIs to prevent abuse. This CL adds a user gesture requirement to those APIs for document picture-in-picture windows to allow them to use those APIs while limiting the potential for abuse. Specification: WICG/document-picture-in-picture#104 Bug: 1354325
cdesouza-chromium
added a commit
to brave/brave-core
that referenced
this pull request
Jan 5, 2024
The override for `LocalDOMWindow::resizeTo` was broken by the addition of an extra exception state argument. This argument is of no consequence to the override itself. This change adjusts the override to pass the exception state along. Chromium change: https://chromium.googlesource.com/chromium/src/+/f17e2aa8de58031d15efa2c0f6de1e0fb48d0b09 commit f17e2aa8de58031d15efa2c0f6de1e0fb48d0b09 Author: Tommy Steimel <steimel@chromium.org> Date: Wed Nov 29 17:32:08 2023 +0000 [document pip] Allow resizeTo()/resizeBy() via user gesture Currently, we don't allow picture-in-picture windows to use the resizeTo() and resizeBy() APIs to prevent abuse. This CL adds a user gesture requirement to those APIs for document picture-in-picture windows to allow them to use those APIs while limiting the potential for abuse. Specification: WICG/document-picture-in-picture#104 Bug: 1354325
cdesouza-chromium
added a commit
to brave/brave-core
that referenced
this pull request
Jan 8, 2024
The override for `LocalDOMWindow::resizeTo` was broken by the addition of an extra exception state argument. This argument is of no consequence to the override itself. This change adjusts the override to pass the exception state along. Chromium change: https://chromium.googlesource.com/chromium/src/+/f17e2aa8de58031d15efa2c0f6de1e0fb48d0b09 commit f17e2aa8de58031d15efa2c0f6de1e0fb48d0b09 Author: Tommy Steimel <steimel@chromium.org> Date: Wed Nov 29 17:32:08 2023 +0000 [document pip] Allow resizeTo()/resizeBy() via user gesture Currently, we don't allow picture-in-picture windows to use the resizeTo() and resizeBy() APIs to prevent abuse. This CL adds a user gesture requirement to those APIs for document picture-in-picture windows to allow them to use those APIs while limiting the potential for abuse. Specification: WICG/document-picture-in-picture#104 Bug: 1354325
mkarolin
pushed a commit
to brave/brave-core
that referenced
this pull request
Jan 9, 2024
The override for `LocalDOMWindow::resizeTo` was broken by the addition of an extra exception state argument. This argument is of no consequence to the override itself. This change adjusts the override to pass the exception state along. Chromium change: https://chromium.googlesource.com/chromium/src/+/f17e2aa8de58031d15efa2c0f6de1e0fb48d0b09 commit f17e2aa8de58031d15efa2c0f6de1e0fb48d0b09 Author: Tommy Steimel <steimel@chromium.org> Date: Wed Nov 29 17:32:08 2023 +0000 [document pip] Allow resizeTo()/resizeBy() via user gesture Currently, we don't allow picture-in-picture windows to use the resizeTo() and resizeBy() APIs to prevent abuse. This CL adds a user gesture requirement to those APIs for document picture-in-picture windows to allow them to use those APIs while limiting the potential for abuse. Specification: WICG/document-picture-in-picture#104 Bug: 1354325
cdesouza-chromium
added a commit
to brave/brave-core
that referenced
this pull request
Jan 10, 2024
The override for `LocalDOMWindow::resizeTo` was broken by the addition of an extra exception state argument. This argument is of no consequence to the override itself. This change adjusts the override to pass the exception state along. Chromium change: https://chromium.googlesource.com/chromium/src/+/f17e2aa8de58031d15efa2c0f6de1e0fb48d0b09 commit f17e2aa8de58031d15efa2c0f6de1e0fb48d0b09 Author: Tommy Steimel <steimel@chromium.org> Date: Wed Nov 29 17:32:08 2023 +0000 [document pip] Allow resizeTo()/resizeBy() via user gesture Currently, we don't allow picture-in-picture windows to use the resizeTo() and resizeBy() APIs to prevent abuse. This CL adds a user gesture requirement to those APIs for document picture-in-picture windows to allow them to use those APIs while limiting the potential for abuse. Specification: WICG/document-picture-in-picture#104 Bug: 1354325
cdesouza-chromium
added a commit
to brave/brave-core
that referenced
this pull request
Jan 11, 2024
The override for `LocalDOMWindow::resizeTo` was broken by the addition of an extra exception state argument. This argument is of no consequence to the override itself. This change adjusts the override to pass the exception state along. Chromium change: https://chromium.googlesource.com/chromium/src/+/f17e2aa8de58031d15efa2c0f6de1e0fb48d0b09 commit f17e2aa8de58031d15efa2c0f6de1e0fb48d0b09 Author: Tommy Steimel <steimel@chromium.org> Date: Wed Nov 29 17:32:08 2023 +0000 [document pip] Allow resizeTo()/resizeBy() via user gesture Currently, we don't allow picture-in-picture windows to use the resizeTo() and resizeBy() APIs to prevent abuse. This CL adds a user gesture requirement to those APIs for document picture-in-picture windows to allow them to use those APIs while limiting the potential for abuse. Specification: WICG/document-picture-in-picture#104 Bug: 1354325
mkarolin
pushed a commit
to brave/brave-core
that referenced
this pull request
Jan 12, 2024
The override for `LocalDOMWindow::resizeTo` was broken by the addition of an extra exception state argument. This argument is of no consequence to the override itself. This change adjusts the override to pass the exception state along. Chromium change: https://chromium.googlesource.com/chromium/src/+/f17e2aa8de58031d15efa2c0f6de1e0fb48d0b09 commit f17e2aa8de58031d15efa2c0f6de1e0fb48d0b09 Author: Tommy Steimel <steimel@chromium.org> Date: Wed Nov 29 17:32:08 2023 +0000 [document pip] Allow resizeTo()/resizeBy() via user gesture Currently, we don't allow picture-in-picture windows to use the resizeTo() and resizeBy() APIs to prevent abuse. This CL adds a user gesture requirement to those APIs for document picture-in-picture windows to allow them to use those APIs while limiting the potential for abuse. Specification: WICG/document-picture-in-picture#104 Bug: 1354325
mkarolin
pushed a commit
to brave/brave-core
that referenced
this pull request
Jan 12, 2024
The override for `LocalDOMWindow::resizeTo` was broken by the addition of an extra exception state argument. This argument is of no consequence to the override itself. This change adjusts the override to pass the exception state along. Chromium change: https://chromium.googlesource.com/chromium/src/+/f17e2aa8de58031d15efa2c0f6de1e0fb48d0b09 commit f17e2aa8de58031d15efa2c0f6de1e0fb48d0b09 Author: Tommy Steimel <steimel@chromium.org> Date: Wed Nov 29 17:32:08 2023 +0000 [document pip] Allow resizeTo()/resizeBy() via user gesture Currently, we don't allow picture-in-picture windows to use the resizeTo() and resizeBy() APIs to prevent abuse. This CL adds a user gesture requirement to those APIs for document picture-in-picture windows to allow them to use those APIs while limiting the potential for abuse. Specification: WICG/document-picture-in-picture#104 Bug: 1354325
cdesouza-chromium
added a commit
to brave/brave-core
that referenced
this pull request
Jan 15, 2024
The override for `LocalDOMWindow::resizeTo` was broken by the addition of an extra exception state argument. This argument is of no consequence to the override itself. This change adjusts the override to pass the exception state along. Chromium change: https://chromium.googlesource.com/chromium/src/+/f17e2aa8de58031d15efa2c0f6de1e0fb48d0b09 commit f17e2aa8de58031d15efa2c0f6de1e0fb48d0b09 Author: Tommy Steimel <steimel@chromium.org> Date: Wed Nov 29 17:32:08 2023 +0000 [document pip] Allow resizeTo()/resizeBy() via user gesture Currently, we don't allow picture-in-picture windows to use the resizeTo() and resizeBy() APIs to prevent abuse. This CL adds a user gesture requirement to those APIs for document picture-in-picture windows to allow them to use those APIs while limiting the potential for abuse. Specification: WICG/document-picture-in-picture#104 Bug: 1354325
mkarolin
pushed a commit
to brave/brave-core
that referenced
this pull request
Jan 15, 2024
The override for `LocalDOMWindow::resizeTo` was broken by the addition of an extra exception state argument. This argument is of no consequence to the override itself. This change adjusts the override to pass the exception state along. Chromium change: https://chromium.googlesource.com/chromium/src/+/f17e2aa8de58031d15efa2c0f6de1e0fb48d0b09 commit f17e2aa8de58031d15efa2c0f6de1e0fb48d0b09 Author: Tommy Steimel <steimel@chromium.org> Date: Wed Nov 29 17:32:08 2023 +0000 [document pip] Allow resizeTo()/resizeBy() via user gesture Currently, we don't allow picture-in-picture windows to use the resizeTo() and resizeBy() APIs to prevent abuse. This CL adds a user gesture requirement to those APIs for document picture-in-picture windows to allow them to use those APIs while limiting the potential for abuse. Specification: WICG/document-picture-in-picture#104 Bug: 1354325
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the idea in #103 to allow the resize APIs behind a user gesture