Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Spec] Elaborate on opaque-ads fenced frame size restrictions #22

Open
gtanzer opened this issue Mar 30, 2022 · 2 comments
Open

[Spec] Elaborate on opaque-ads fenced frame size restrictions #22

gtanzer opened this issue Mar 30, 2022 · 2 comments

Comments

@gtanzer
Copy link
Collaborator

gtanzer commented Mar 30, 2022

The frame size is frozen at first navigation and coerced to the nearest allowed size.
@gtanzer
Copy link
Collaborator Author

gtanzer commented Apr 12, 2022

Design doc (WIP): https://docs.google.com/document/d/1MVqxc2nzde3cJYIRC8vnXH-a4A6J4GQE-1vBuXhQsPE/edit#heading=h.67vioho3x0ux

The tentative list of options is:

Fixed sizes:
320x50
728x90
970x90
320x100
160x600
300x250
970x250
336x280
320x480
300x600
300x1050

Fixed-height flexible sizes (H):
In mobile devices with viewport width vw, we also accept sizes (vw)xh, where h is one of {50, 100, 250}. For instance, in a device with viewport width 360, the sizes 360x50, 360x100, 360x250 are also valid sizes.

Fixed-aspect ratio flexible sizes (AR):
In mobiles devices with viewport width vw, we also accept sizes (vw)x(vw/k), where k is one of {6.4, 3.2, 1.2, 2/3, 1/2}, rounding to the nearest integer (half up). For instance, in a device with viewport width 412, the sizes 412x64, 412x129, 412x343, 412x618 and 412x824 are also valid sizes.

aarongable pushed a commit to chromium/chromium that referenced this issue Apr 14, 2022
Fenced Frames: Restrict fenced frames to a list of ad sizes on first …
4054611 
…navigation

Known issues:
* Filed a bug for a preexisting issue where we hit a DCHECK on Linux when a fenced frame (or div+iframe) is slightly scrollable: https://crbug.com/1307469
* Resize observer is asynchronous, so the semantics are much more nondeterministic than we want. (In the first rendering frame that the fenced frame exists, basically anything goes.)
* If the fenced frame has no specified size (i.e. takes the default), when the ResizeObserver handler sets the size of the inner container, the outer container seems to inherit this size. In WPT but not interactive usage, this causes an error due to resize observations coming in too quickly, which we add expected output for.

Design doc: https://docs.google.com/document/d/1MVqxc2nzde3cJYIRC8vnXH-a4A6J4GQE-1vBuXhQsPE/edit#

Spec issue: WICG/fenced-frame#22

Bug: 1123606
Change-Id: I628b548cc1c747a76893e762fa621966bdfcfb94
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3569887
Reviewed-by: Shivani Sharma <shivanisha@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Garrett Tanzer <gtanzer@chromium.org>
Cr-Commit-Position: refs/heads/main@{#992647}
@michal-kalisz michal-kalisz mentioned this issue Jun 14, 2022
Open
mjfroman pushed a commit to mjfroman/moz-libwebrtc-third-party that referenced this issue Oct 14, 2022
Fenced Frames: Restrict fenced frames to a list of ad sizes on first …
2b9935a 
…navigation

Known issues:
* Filed a bug for a preexisting issue where we hit a DCHECK on Linux when a fenced frame (or div+iframe) is slightly scrollable: https://crbug.com/1307469
* Resize observer is asynchronous, so the semantics are much more nondeterministic than we want. (In the first rendering frame that the fenced frame exists, basically anything goes.)
* If the fenced frame has no specified size (i.e. takes the default), when the ResizeObserver handler sets the size of the inner container, the outer container seems to inherit this size. In WPT but not interactive usage, this causes an error due to resize observations coming in too quickly, which we add expected output for.

Design doc: https://docs.google.com/document/d/1MVqxc2nzde3cJYIRC8vnXH-a4A6J4GQE-1vBuXhQsPE/edit#

Spec issue: WICG/fenced-frame#22

Bug: 1123606
Change-Id: I628b548cc1c747a76893e762fa621966bdfcfb94
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3569887
Reviewed-by: Shivani Sharma <shivanisha@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Garrett Tanzer <gtanzer@chromium.org>
Cr-Commit-Position: refs/heads/main@{#992647}
NOKEYCHECK=True
GitOrigin-RevId: 40546119ee3f1572f99b868a35988fdf8a0573ce
@craigfrancis
Copy link

Related, it would be important for anything that isn’t a fixed sized ad, for the frame height to be set automatically, this has been raised for iframes: w3c/csswg-drafts#1771

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@craigfrancis @gtanzer