Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make FencedFrameConfig IDL objects serializable #111

Merged
merged 6 commits into from Aug 26, 2023

Conversation

blu25
Copy link
Collaborator

@blu25 blu25 commented Aug 18, 2023

This PR:

  • Makes FencedFrameConfig objects serializable and defines serializing/deserializing steps for it.
  • Removes config as an attribute of a FencedFrameConfig, replacing it with a clone of the values it needs from the internal Fenced Frame Config struct.
  • Passes in the sharedStorageContext directly to the navigate algorithm, which will read the sharedStorageContext from the IDL object to the embedder shared storage context in the Fenced Frame Config struct. This is done since we are no longer writing directly to the Fenced Frame Config struct in the setSharedStorageContext() algorithm.
  • Modifies getNestedConfigs() to account for the changes to FencedFrameConfig.
  • Update the step number for the navigate step that goes in parallel.
  • Update the permissions policy introduction section to mention the internal [=fenced frame config=] struct instead of the {{FencedFrameConfig}} IDL object.

Preview | Diff

@blu25 blu25 requested a review from domfarolino August 18, 2023 17:02
spec.bs Outdated Show resolved Hide resolved
spec.bs Outdated Show resolved Hide resolved
spec.bs Outdated Show resolved Hide resolved
spec.bs Outdated Show resolved Hide resolved
spec.bs Outdated Show resolved Hide resolved
spec.bs Outdated Show resolved Hide resolved
Copy link
Collaborator

@domfarolino domfarolino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty much lgtm % one nit!

spec.bs Outdated Show resolved Hide resolved
@domfarolino domfarolino merged commit cf06e42 into master Aug 26, 2023
2 checks passed
@domfarolino domfarolino deleted the liam-serializable-config branch August 26, 2023 11:54
github-actions bot added a commit that referenced this pull request Aug 26, 2023
SHA: cf06e42
Reason: push, by domfarolino

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants