Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use spec-prod instead of a Makefile to build the spec. #51

Merged
merged 2 commits into from Sep 26, 2022
Merged

Use spec-prod instead of a Makefile to build the spec. #51

merged 2 commits into from Sep 26, 2022

Conversation

jyasskin
Copy link
Member

@jyasskin jyasskin commented Sep 21, 2022 •
edited by pr-preview bot

This generally produces better error messages than curl.

Preview | Diff

@domfarolino
Copy link
Collaborator

domfarolino commented Sep 21, 2022 •
edited

Looks like this PR deletes the Makefile? What is the preferred way to build the spec locally? (I'm not familiar with spec-prod)

@jyasskin
Copy link
Member Author

I could undelete the Makefile if people are actively using it. I'd always install Bikeshed locally and run bikeshed or bikeshed watch.

@domfarolino
Copy link
Collaborator

Hmm, I think make remote is pretty useful for people that don't have bikeshed installed, plus we still have the Makefiles in many WHATWG specs (DOM, Fetch, URL, etc) so it seems like good practice to keep it around?

@jyasskin
Copy link
Member Author

Works for me. I've restored it, with just the make ci target removed.

@jyasskin
Copy link
Member Author

(Part of the reason the WHATWG specs have Makefiles is that they have the COMMIT-SHA text macro, so raw bikeshed invocations actually fail. But I'm still fine with having Makefiles if the people actively developing a spec want them.)

domfarolino
domfarolino approved these changes Sep 22, 2022
View reviewed changes
.github/workflows/build.yml Show resolved Hide resolved
@domfarolino domfarolino merged commit 050074d into WICG:master Sep 26, 2022
github-actions bot added a commit that referenced this pull request Sep 26, 2022
@jyasskin @github-actions
Use spec-prod instead of a Makefile to build the spec. (#51)
062f6bd 
SHA: 050074d
Reason: push, by @domfarolino

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@jyasskin jyasskin deleted the spec-prod branch September 26, 2022 14:39
@pythagoraskitty pythagoraskitty mentioned this pull request Sep 27, 2022
Merged
@domfarolino domfarolino mentioned this pull request Oct 17, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@domfarolino domfarolino domfarolino approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jyasskin @domfarolino