Change the API for exposing the sandboxed file system. #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@inexorabletash @pwnall what do you think of this change? Decoupling sandboxed file system from "special/system/standard/well known" directories seems like it would be less confusing to me... |
mkruisselbrink
requested review from
inexorabletash and
pwnall
and removed request for
inexorabletash
inexorabletash
approved these changes
Apr 17, 2020
| }; | ||
| </xmp> | ||
|
|
||
| Advisement: In Chrome this functionality is currently exposed as `FileSystemDirectoryHandle.getSystemDirectory({type: "sandbox"})`. |
There was a problem hiding this comment.
Add the milestone? I also like tossing in 🚧 markers, but I'm silly that way.
There was a problem hiding this comment.
Well, currently it's all milestones... Once we've implemented these changes I definitely want to go back and update this to mention milestones, just not sure what milestone to mention now.
mkruisselbrink
added a commit
that referenced
this pull request
May 27, 2020
This method was renamed/moved in #174, but unintentionally that change also started limiting the API to only be available in windows. This changes it back to also expose the origin private directory to workers.
mkruisselbrink
added a commit
that referenced
this pull request
May 28, 2020
This method was renamed/moved in #174, but unintentionally that change also started limiting the API to only be available in windows. This changes it back to also expose the origin private directory to workers.
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
May 29, 2020
In WICG/file-system-access#174 the spec for how sandboxed FS is exposed was change, this updates to implementation to match the spec. R=mek@chromium.org https://bugs.chromium.org/p/chromium/issues/detail?id=1081287#c2 Change-Id: I0e381c873db98e30baed6679be048031b385cc50
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Jun 1, 2020
In WICG/file-system-access#174 the spec for how sandboxed FS is exposed was change, this updates to implementation to match the spec. R=mek@chromium.org https://bugs.chromium.org/p/chromium/issues/detail?id=1081287#c2 Change-Id: I0e381c873db98e30baed6679be048031b385cc50
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Jun 1, 2020
In WICG/file-system-access#174 the spec for how sandboxed FS is exposed was change, this updates to implementation to match the spec. R=mek@chromium.org Bug: 1081287 Change-Id: I0e381c873db98e30baed6679be048031b385cc50
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Jun 2, 2020
In WICG/file-system-access#174 the spec for how sandboxed FS is exposed was change, this updates to implementation to match the spec. R=mek@chromium.org Bug: 1081287 Change-Id: I0e381c873db98e30baed6679be048031b385cc50
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Jun 3, 2020
In WICG/file-system-access#174 the spec for how sandboxed FS is exposed was change, this updates to implementation to match the spec. R=mek@chromium.org Bug: 1081287 Change-Id: I0e381c873db98e30baed6679be048031b385cc50
pull bot
pushed a commit
to Yannic/chromium
that referenced
this pull request
Jun 3, 2020
In WICG/file-system-access#174 the spec for how sandboxed FS is exposed was change, this updates to implementation to match the spec. R=mek@chromium.org Bug: 1081287 Change-Id: I0e381c873db98e30baed6679be048031b385cc50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220685 Commit-Queue: Hazim Mohamed <hazimmohamed@google.com> Reviewed-by: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#774745}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Jun 3, 2020
In WICG/file-system-access#174 the spec for how sandboxed FS is exposed was change, this updates to implementation to match the spec. R=mek@chromium.org Bug: 1081287 Change-Id: I0e381c873db98e30baed6679be048031b385cc50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220685 Commit-Queue: Hazim Mohamed <hazimmohamed@google.com> Reviewed-by: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#774745}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Jun 3, 2020
In WICG/file-system-access#174 the spec for how sandboxed FS is exposed was change, this updates to implementation to match the spec. R=mek@chromium.org Bug: 1081287 Change-Id: I0e381c873db98e30baed6679be048031b385cc50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220685 Commit-Queue: Hazim Mohamed <hazimmohamed@google.com> Reviewed-by: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#774745}
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Jun 13, 2020
…getOriginPrivateDirectory., a=testonly Automatic update from web-platform-tests [NativeFS] Change getSystemDirectory to getOriginPrivateDirectory. In WICG/file-system-access#174 the spec for how sandboxed FS is exposed was change, this updates to implementation to match the spec. R=mek@chromium.org Bug: 1081287 Change-Id: I0e381c873db98e30baed6679be048031b385cc50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220685 Commit-Queue: Hazim Mohamed <hazimmohamed@google.com> Reviewed-by: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#774745} -- wpt-commits: 1e1431774d766756367132d3c976aeaf8998a8d0 wpt-pr: 23844
xeonchen
pushed a commit
to xeonchen/gecko
that referenced
this pull request
Jun 13, 2020
…getOriginPrivateDirectory., a=testonly Automatic update from web-platform-tests [NativeFS] Change getSystemDirectory to getOriginPrivateDirectory. In WICG/file-system-access#174 the spec for how sandboxed FS is exposed was change, this updates to implementation to match the spec. R=mek@chromium.org Bug: 1081287 Change-Id: I0e381c873db98e30baed6679be048031b385cc50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220685 Commit-Queue: Hazim Mohamed <hazimmohamed@google.com> Reviewed-by: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#774745} -- wpt-commits: 1e1431774d766756367132d3c976aeaf8998a8d0 wpt-pr: 23844
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Jun 15, 2020
…getOriginPrivateDirectory., a=testonly Automatic update from web-platform-tests [NativeFS] Change getSystemDirectory to getOriginPrivateDirectory. In WICG/file-system-access#174 the spec for how sandboxed FS is exposed was change, this updates to implementation to match the spec. R=mekchromium.org Bug: 1081287 Change-Id: I0e381c873db98e30baed6679be048031b385cc50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220685 Commit-Queue: Hazim Mohamed <hazimmohamedgoogle.com> Reviewed-by: Marijn Kruisselbrink <mekchromium.org> Reviewed-by: Jeremy Roman <jbromanchromium.org> Cr-Commit-Position: refs/heads/master{#774745} -- wpt-commits: 1e1431774d766756367132d3c976aeaf8998a8d0 wpt-pr: 23844 UltraBlame original commit: 016c68d65e2ca46987d11f9c1ba4872652f2aa47
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Jun 15, 2020
…getOriginPrivateDirectory., a=testonly Automatic update from web-platform-tests [NativeFS] Change getSystemDirectory to getOriginPrivateDirectory. In WICG/file-system-access#174 the spec for how sandboxed FS is exposed was change, this updates to implementation to match the spec. R=mekchromium.org Bug: 1081287 Change-Id: I0e381c873db98e30baed6679be048031b385cc50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220685 Commit-Queue: Hazim Mohamed <hazimmohamedgoogle.com> Reviewed-by: Marijn Kruisselbrink <mekchromium.org> Reviewed-by: Jeremy Roman <jbromanchromium.org> Cr-Commit-Position: refs/heads/master{#774745} -- wpt-commits: 1e1431774d766756367132d3c976aeaf8998a8d0 wpt-pr: 23844 UltraBlame original commit: 016c68d65e2ca46987d11f9c1ba4872652f2aa47
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Jun 15, 2020
…getOriginPrivateDirectory., a=testonly Automatic update from web-platform-tests [NativeFS] Change getSystemDirectory to getOriginPrivateDirectory. In WICG/file-system-access#174 the spec for how sandboxed FS is exposed was change, this updates to implementation to match the spec. R=mekchromium.org Bug: 1081287 Change-Id: I0e381c873db98e30baed6679be048031b385cc50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220685 Commit-Queue: Hazim Mohamed <hazimmohamedgoogle.com> Reviewed-by: Marijn Kruisselbrink <mekchromium.org> Reviewed-by: Jeremy Roman <jbromanchromium.org> Cr-Commit-Position: refs/heads/master{#774745} -- wpt-commits: 1e1431774d766756367132d3c976aeaf8998a8d0 wpt-pr: 23844 UltraBlame original commit: 016c68d65e2ca46987d11f9c1ba4872652f2aa47
mjfroman
pushed a commit
to mjfroman/moz-libwebrtc-third-party
that referenced
this pull request
Oct 14, 2022
In WICG/file-system-access#174 the spec for how sandboxed FS is exposed was change, this updates to implementation to match the spec. R=mek@chromium.org Bug: 1081287 Change-Id: I0e381c873db98e30baed6679be048031b385cc50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220685 Commit-Queue: Hazim Mohamed <hazimmohamed@google.com> Reviewed-by: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by: Jeremy Roman <jbroman@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#774745} Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src Cr-Mirrored-Commit: bf91fb3db45cd21478447f59fecd0cf7bc4924c0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also explain what and why the sandboxed file system is.
This fixes #66 and partially addresses #27.
Preview | Diff