Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editorial: Replace backticks with quotes in broken drag-and-drop example #424

Closed
wants to merge 1 commit into from

Conversation

a-sully
Copy link
Collaborator

@a-sully a-sully commented Jul 12, 2023

This was accidentally broken in #357


Preview | Diff

@mkruisselbrink
Copy link
Contributor

I'm pretty sure the backticks are intentional? https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Template_literals

@inexorabletash
Copy link
Member

Agreed w/ @mkruisselbrink - the backticks seem correct

(I'd just leave an emoji but I was tagged as a reviewer)

@a-sully
Copy link
Collaborator Author

a-sully commented Jul 12, 2023

https://wicg.github.io/file-system-access/#draganddrop-example is broken as-is (presumably because it's within an <xmp> tag?)

@inexorabletash
Copy link
Member

Bikeshed was just updated to fix handling of ` in examples. Update and re-run bikeshed locally?

@a-sully
Copy link
Collaborator Author

a-sully commented Jul 12, 2023

Ah I see. It works locally with backticks. Presumably https://wicg.github.io/file-system-access will update eventually?... Or does it need some trigger (like some PR merging)?

@inexorabletash
Copy link
Member

And if that doesn't work, consider using backtick-backtick-backtick-js .... backtick-backtick-backtick instead of xmp

@inexorabletash
Copy link
Member

I kicked off a re-run of the action. Should be fixed in a few minutes.

@a-sully
Copy link
Collaborator Author

a-sully commented Jul 12, 2023

Awesome, thanks!

@a-sully a-sully closed this Jul 12, 2023
@a-sully a-sully deleted the fix-drag-drop-example branch July 12, 2023 17:51
@inexorabletash
Copy link
Member

Hmmm, didn't seem to do it. I'll keep poking.

@inexorabletash
Copy link
Member

Okay good now. Needed to rerun the CI action, which is a prerequisite and automatically triggers the pages-build-deployment action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants