Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

showDirectoryPicker always returns 1 handle #443

Merged
merged 1 commit into from
Mar 20, 2024
Merged

showDirectoryPicker always returns 1 handle #443

merged 1 commit into from
Mar 20, 2024

Conversation

vapier
Copy link
Contributor

@vapier vapier commented Mar 19, 2024 •
edited by pr-preview bot
Loading

tomayac
tomayac approved these changes Mar 20, 2024
View reviewed changes
Copy link
Contributor

@tomayac tomayac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, approval

@a-sully
Copy link
Collaborator

a-sully commented Mar 20, 2024

@vapier the bot won't let you merge this PR until you join the working group. See https://labs.w3.org/repo-manager/pr/id/WICG/file-system-access/443

@vapier
Copy link
Contributor Author

vapier commented Mar 20, 2024

that's kind of a lot of red tape. i can see why some people would not bother contributing. but i guess that's not specific to this API proposal.

i logged in with my account (that i luckily have) and smashed a lot of buttons. guess we'll see what happens.

@w3cbot
Copy link

w3cbot commented Mar 20, 2024

a-sully marked as non substantive for IPR from ash-nazg.

@a-sully
Copy link
Collaborator

a-sully commented Mar 20, 2024

that's kind of a lot of red tape

Ah yes, I just remembered this button, which applies here

a-sully marked as non substantive for IPR from ash-nazg.

@a-sully a-sully merged commit f443f21 into WICG:main Mar 20, 2024
2 checks passed
github-actions bot added a commit that referenced this pull request Mar 20, 2024
@vapier @github-actions
chore(rebuild): showDirectoryPicker always returns 1 handle (#443)
b08530a 
SHA: f443f21
Reason: push, by @a-sully

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomayac tomayac tomayac approved these changes

@a-sully a-sully a-sully approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@vapier @a-sully @w3cbot @tomayac