Prevent backtracking above /-prefix entries #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #207. Also changes the error message suggestion for a nearby case to be more helpful and accurate.
guybedford
approved these changes
Oct 24, 2020
hiroshige-g
reviewed
Dec 2, 2020
| @@ -6,7 +6,8 @@ | |||
| "lodash-dot": "./node_modules/lodash-es/lodash.js", | |||
| "lodash-dot/": "./node_modules/lodash-es/", | |||
| "lodash-dotdot": "../node_modules/lodash-es/lodash.js", | |||
| "lodash-dotdot/": "../node_modules/lodash-es/" | |||
| "lodash-dotdot/": "../node_modules/lodash-es/", | |||
| "mapped/path/": "https://github.com/WICG/import-maps/issues/207/" | |||
There was a problem hiding this comment.
Could you add an entry of "mapped/" here, and "mapped/backtrack" to the expectedResults below?
This is to test that the backtracking failure at a more specific key doesn't allow fallback to less specific key -- i.e. "mapped/path/../backtrack" can't be resolved while "mapped/backtrack" can be resolved.
hiroshige-g
reviewed
Dec 2, 2020
| @@ -6,7 +6,8 @@ | |||
| "lodash-dot": "./node_modules/lodash-es/lodash.js", | |||
| "lodash-dot/": "./node_modules/lodash-es/", | |||
| "lodash-dotdot": "../node_modules/lodash-es/lodash.js", | |||
| "lodash-dotdot/": "../node_modules/lodash-es/" | |||
| "lodash-dotdot/": "../node_modules/lodash-es/", | |||
| "mapped/path/": "https://github.com/WICG/import-maps/issues/207/" | |||
| } | |||
There was a problem hiding this comment.
Also, how about adding test cases for URL-like specfiers + backtracking? (perhaps in url-specifiers.json, where URL-like specifiers + trailing slash is tested)
hiroshige-g
approved these changes
Dec 2, 2020
|
Note to self: PR title is wrong; it should be |
blueboxd
pushed a commit
to blueboxd/chromium-legacy
that referenced
this pull request
Dec 5, 2020
Reflecting WICG/import-maps#229 Bug: 848607, WICG/import-maps#207 Change-Id: Id056b3fd27489ecdfe45456220fd1d8c01dc8d3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570012 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by: Kouhei Ueno <kouhei@chromium.org> Reviewed-by: Domenic Denicola <domenic@chromium.org> Cr-Commit-Position: refs/heads/master@{#833945}
mjfroman
pushed a commit
to mjfroman/moz-libwebrtc-third-party
that referenced
this pull request
Oct 14, 2022
Reflecting WICG/import-maps#229 Bug: 848607, WICG/import-maps#207 Change-Id: Id056b3fd27489ecdfe45456220fd1d8c01dc8d3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570012 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by: Kouhei Ueno <kouhei@chromium.org> Reviewed-by: Domenic Denicola <domenic@chromium.org> Cr-Commit-Position: refs/heads/master@{#833945} GitOrigin-RevId: 916cc2354cae22a6e8280f2a2b7ac66b30b99e67
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #207.
Also changes the error message suggestion for a nearby case to be more helpful and accurate.
Preview | Diff