Update prefetch spec after whatwg/html#6315. #212

jeremyroman · 2022-11-17T23:39:55Z

This is a fairly comprehensive rewrite so hopefully it both respects the new navigables/etc infrastructure and reflects the previously specified functionality.

…changes for redirect handling, process-a-navigate-fetch, etc

…ms algorithm

jeremyroman · 2022-11-17T23:41:08Z

It builds locally; once the prerendering.bs fixes land I'll retrigger the preview bot. In the meantime at least this still works: https://api.csswg.org/bikeshed/?url=https://raw.githubusercontent.com/jeremyroman/nav-speculation/prefetch-6315/prefetch.bs

jeremyroman · 2022-11-17T23:41:26Z

@domenic ptal when you get the chance? I know it's kinda a huge diff.

domenic

Nice work!

prefetch.bs

domenic · 2022-11-21T01:32:02Z

prefetch.bs

-        1. If |request|'s [=request/URL=] is not [=potentially trustworthy URL|potentially trustworthy=], then return "`Blocked`".
+        1. Let |proposedPartitionKey| be the result of [=determining the network partition key=] given |request|'s [=request/reserved client=].
+        1. If |partitioningScheme| is "`same-partition`" and |proposedPartitionKey| is not equal to |sourcePartitionKey|, then return "`Blocked`".
+        1. Otherwise, if |partitioningScheme| is "`uncredentialed`" and |proposedPartitionKey| is equal to |sourcePartitionKey|, then return "`Blocked`".


I think this blocks same-origin prefetches on totally-uncredentialed origins. Is that intentional?

I don't think that's the case, given this "uncredentialed" is only used when we've asked for a cross-partition prefetch.

In resolving your other comment this has ended up being perhaps more clear that "uncredentialed" here really means "we're crossing partitions, so we have to isolate ourselves from any existing credentials".

Co-authored-by: Domenic Denicola <d@domenic.me>

… navigations. This came up during a spec PR review: WICG/nav-speculation#212 Change-Id: Ia8fb3d6c9b164fa35b196b99f1feb5750ec359f9

github-actions · 2022-11-29T19:07:08Z

Preview:

Co-authored-by: Domenic Denicola <d@domenic.me>

…ulation into prefetch-6315

jeremyroman

Responding to most comments. The question about whether to just make "create navigation params by fetching" explicitly aware of prefetch is an interesting one which I'll need to think a little more about.

prefetch.bs

jeremyroman · 2022-11-29T18:51:55Z

prefetch.bs

-                <p class="issue">At the moment, how IP anonymization is achieved is handwaved. This will probably be done in an [=implementation-defined=] manner using some kind of proxy or relay. Ideally this would be plumbed down to [=obtain a connection=], and possibly even the mechanism could be further standardized.</p>
-        1. [=header list/Set a structured field value=] given (<a http-header>`` `Sec-Purpose` ``</a>, |purpose|) in |request|'s [=request/header list=].
+<div algorithm="attempt to populate the history entry's document">
+    In <a spec=HTML>attempt to populate the history entry's document</a>, replace the step which invokes <a spec=HTML>create navigation params by fetching</a> with the following:


What a fun edge case. It seems the Chromium implementation does currently admit this for both traversal and reload navigations.

Adding a WPT for this: https://chromium-review.googlesource.com/c/chromium/src/+/4062248

prefetch.bs

… navigations. This came up during a spec PR review: WICG/nav-speculation#212 Change-Id: Ia8fb3d6c9b164fa35b196b99f1feb5750ec359f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4062248 Reviewed-by: Adithya Srinivasan <adithyas@chromium.org> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Auto-Submit: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/main@{#1077079}

…d reload navigations." This reverts commit 1b56f238b3405214bbb11c8caf451735690219b4. Reason for revert: Test is failing on many Mac bots, see crbug.com/1394569 Original change's description: > prefetch: Add WPT showing that prefetch can match traverse and reload navigations. > > This came up during a spec PR review: > WICG/nav-speculation#212 > > Change-Id: Ia8fb3d6c9b164fa35b196b99f1feb5750ec359f9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4062248 > Reviewed-by: Adithya Srinivasan <adithyas@chromium.org> > Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> > Auto-Submit: Jeremy Roman <jbroman@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1077079} Bug: 1394569 Change-Id: I0943c75654ec4f8639713994cb390c7ed4e2e636 No-Presubmit: true No-Tree-Checks: true No-Try: true

…d reload navigations." This reverts commit 1b56f23. Reason for revert: Test is failing on many Mac bots, see crbug.com/1394569 Original change's description: > prefetch: Add WPT showing that prefetch can match traverse and reload navigations. > > This came up during a spec PR review: > WICG/nav-speculation#212 > > Change-Id: Ia8fb3d6c9b164fa35b196b99f1feb5750ec359f9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4062248 > Reviewed-by: Adithya Srinivasan <adithyas@chromium.org> > Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> > Auto-Submit: Jeremy Roman <jbroman@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1077079} Bug: 1394569 Change-Id: I0943c75654ec4f8639713994cb390c7ed4e2e636 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4064343 Owners-Override: Marc Treib <treib@chromium.org> Reviewed-by: Mikel Astiz <mastiz@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/main@{#1077358}

…d reload navigations." This reverts commit 1b56f238b3405214bbb11c8caf451735690219b4. Reason for revert: Test is failing on many Mac bots, see crbug.com/1394569 Original change's description: > prefetch: Add WPT showing that prefetch can match traverse and reload navigations. > > This came up during a spec PR review: > WICG/nav-speculation#212 > > Change-Id: Ia8fb3d6c9b164fa35b196b99f1feb5750ec359f9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4062248 > Reviewed-by: Adithya Srinivasan <adithyas@chromium.org> > Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> > Auto-Submit: Jeremy Roman <jbroman@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1077079} Bug: 1394569 Change-Id: I0943c75654ec4f8639713994cb390c7ed4e2e636 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4064343 Owners-Override: Marc Treib <treib@chromium.org> Reviewed-by: Mikel Astiz <mastiz@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/main@{#1077358}

domenic

Looks like there's still some substantial feedback outstanding. Let me know if you want to box those away into <p class="issue"> boxes so we can move forward; I think that's very reasonable.

prefetch.bs

domenic · 2022-12-02T08:38:09Z

prefetch.bs

-                <p class="issue">At the moment, how IP anonymization is achieved is handwaved. This will probably be done in an [=implementation-defined=] manner using some kind of proxy or relay. Ideally this would be plumbed down to [=obtain a connection=], and possibly even the mechanism could be further standardized.</p>
-        1. [=header list/Set a structured field value=] given (<a http-header>`` `Sec-Purpose` ``</a>, |purpose|) in |request|'s [=request/header list=].
+<div algorithm="attempt to populate the history entry's document">
+    In <a spec=HTML>attempt to populate the history entry's document</a>, replace the step which invokes <a spec=HTML>create navigation params by fetching</a> with the following:


Fun!

Looks like the test got reverted; I hope we can add it back. It's weird that it would be failing on Macs only?

prefetch.bs

…d reload navigations." This reverts commit 1b56f238b3405214bbb11c8caf451735690219b4. Reason for revert: Test is failing on many Mac bots, see crbug.com/1394569 Original change's description: > prefetch: Add WPT showing that prefetch can match traverse and reload navigations. > > This came up during a spec PR review: > WICG/nav-speculation#212 > > Change-Id: Ia8fb3d6c9b164fa35b196b99f1feb5750ec359f9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4062248 > Reviewed-by: Adithya Srinivasan <adithyas@chromium.org> > Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> > Auto-Submit: Jeremy Roman <jbroman@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1077079} Bug: 1394569 Change-Id: I0943c75654ec4f8639713994cb390c7ed4e2e636 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4064343 Owners-Override: Marc Treib <treib@chromium.org> Reviewed-by: Mikel Astiz <mastiz@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/main@{#1077358}

domenic

This looks great, I think merging into "create navigation params by fetching" worked well.

Giving you to the LGTM so that you can merge this at will, but I guess there might still be something worth checking about how we thread through the prefetch record.

prefetch.bs

domenic · 2022-12-09T08:25:25Z

prefetch.bs

-        1. [=redirect chain/Append=] |request| to |prefetchRecord|'s [=prefetch record/redirect chain=].
-        1. Return "`Allowed`".
+Add the following [=struct/item=] to [=session history entry=]:
+* <dfn for="session history entry">prefetch record</dfn>, a [=prefetch record=] or null. If non-null, it indicates that a prefetch, not a normal navigation, is in progress.


It feels weird to store this in session history entry. It seems like it doesn't need to be there long term, and instead is just used because the relevant algorithms take a SHE. Can we instead just thread it to the relevant algorithms as an independent, sometimes-null parameter?

The entire SHE here is admittedly a little fictitious because we're not actually putting it in session history just yet.

Made the suggested change.

…can match traverse and reload navigations., a=testonly Automatic update from web-platform-tests prefetch: Add WPT showing that prefetch can match traverse and reload navigations. This came up during a spec PR review: WICG/nav-speculation#212 Change-Id: Ia8fb3d6c9b164fa35b196b99f1feb5750ec359f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4062248 Reviewed-by: Adithya Srinivasan <adithyas@chromium.org> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Auto-Submit: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/main@{#1077079} -- wpt-commits: 611dc0411c43984c7ab2abfa1810d97d065f7c71 wpt-pr: 37234

…refetch can match traverse and reload navigations.", a=testonly Automatic update from web-platform-tests Revert "prefetch: Add WPT showing that prefetch can match traverse and reload navigations." This reverts commit 1b56f238b3405214bbb11c8caf451735690219b4. Reason for revert: Test is failing on many Mac bots, see crbug.com/1394569 Original change's description: > prefetch: Add WPT showing that prefetch can match traverse and reload navigations. > > This came up during a spec PR review: > WICG/nav-speculation#212 > > Change-Id: Ia8fb3d6c9b164fa35b196b99f1feb5750ec359f9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4062248 > Reviewed-by: Adithya Srinivasan <adithyas@chromium.org> > Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> > Auto-Submit: Jeremy Roman <jbroman@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1077079} Bug: 1394569 Change-Id: I0943c75654ec4f8639713994cb390c7ed4e2e636 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4064343 Owners-Override: Marc Treib <treib@chromium.org> Reviewed-by: Mikel Astiz <mastiz@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/main@{#1077358} -- wpt-commits: db6deadcb828b9f872cc5284667d95ab523e698e wpt-pr: 37248

…d reload navigations." This reverts commit 1b56f238b3405214bbb11c8caf451735690219b4. Reason for revert: Test is failing on many Mac bots, see crbug.com/1394569 Original change's description: > prefetch: Add WPT showing that prefetch can match traverse and reload navigations. > > This came up during a spec PR review: > WICG/nav-speculation#212 > > Change-Id: Ia8fb3d6c9b164fa35b196b99f1feb5750ec359f9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4062248 > Reviewed-by: Adithya Srinivasan <adithyas@chromium.org> > Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> > Auto-Submit: Jeremy Roman <jbroman@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1077079} Bug: 1394569 Change-Id: I0943c75654ec4f8639713994cb390c7ed4e2e636 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4064343 Owners-Override: Marc Treib <treib@chromium.org> Reviewed-by: Mikel Astiz <mastiz@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/main@{#1077358}

…can match traverse and reload navigations., a=testonly Automatic update from web-platform-tests prefetch: Add WPT showing that prefetch can match traverse and reload navigations. This came up during a spec PR review: WICG/nav-speculation#212 Change-Id: Ia8fb3d6c9b164fa35b196b99f1feb5750ec359f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4062248 Reviewed-by: Adithya Srinivasan <adithyas@chromium.org> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Auto-Submit: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/main@{#1077079} -- wpt-commits: 611dc0411c43984c7ab2abfa1810d97d065f7c71 wpt-pr: 37234

…refetch can match traverse and reload navigations.", a=testonly Automatic update from web-platform-tests Revert "prefetch: Add WPT showing that prefetch can match traverse and reload navigations." This reverts commit 1b56f238b3405214bbb11c8caf451735690219b4. Reason for revert: Test is failing on many Mac bots, see crbug.com/1394569 Original change's description: > prefetch: Add WPT showing that prefetch can match traverse and reload navigations. > > This came up during a spec PR review: > WICG/nav-speculation#212 > > Change-Id: Ia8fb3d6c9b164fa35b196b99f1feb5750ec359f9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4062248 > Reviewed-by: Adithya Srinivasan <adithyas@chromium.org> > Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> > Auto-Submit: Jeremy Roman <jbroman@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1077079} Bug: 1394569 Change-Id: I0943c75654ec4f8639713994cb390c7ed4e2e636 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4064343 Owners-Override: Marc Treib <treib@chromium.org> Reviewed-by: Mikel Astiz <mastiz@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/main@{#1077358} -- wpt-commits: db6deadcb828b9f872cc5284667d95ab523e698e wpt-pr: 37248

… navigations. This came up during a spec PR review: WICG/nav-speculation#212 This is a reland of the following, except for extending the timeout. https://chromium-review.googlesource.com/c/chromium/src/+/4062248 Fixed: 1394569 Change-Id: I1ed952f6e1fc065a7213d262dfe5dc86f722f6c8

… navigations. This came up during a spec PR review: WICG/nav-speculation#212 This is a reland of the following, except for extending the timeout. https://chromium-review.googlesource.com/c/chromium/src/+/4062248 Fixed: 1394569 Change-Id: I1ed952f6e1fc065a7213d262dfe5dc86f722f6c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4184810 Reviewed-by: Adithya Srinivasan <adithyas@chromium.org> Auto-Submit: Jeremy Roman <jbroman@chromium.org> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Cr-Commit-Position: refs/heads/main@{#1095624}

… navigations. This came up during a spec PR review: WICG/nav-speculation#212 This is a reland of the following, except for extending the timeout. https://chromium-review.googlesource.com/c/chromium/src/+/4062248 Fixed: 1394569 Change-Id: I1ed952f6e1fc065a7213d262dfe5dc86f722f6c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4184810 Reviewed-by: Adithya Srinivasan <adithyas@chromium.org> Auto-Submit: Jeremy Roman <jbroman@chromium.org> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Cr-Commit-Position: refs/heads/main@{#1095624}

…can match traverse and reload navigations., a=testonly Automatic update from web-platform-tests prefetch: Add WPT showing that prefetch can match traverse and reload navigations. This came up during a spec PR review: WICG/nav-speculation#212 This is a reland of the following, except for extending the timeout. https://chromium-review.googlesource.com/c/chromium/src/+/4062248 Fixed: 1394569 Change-Id: I1ed952f6e1fc065a7213d262dfe5dc86f722f6c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4184810 Reviewed-by: Adithya Srinivasan <adithyas@chromium.org> Auto-Submit: Jeremy Roman <jbroman@chromium.org> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Cr-Commit-Position: refs/heads/main@{#1095624} -- wpt-commits: eb8a9702e01eb3ce887ab3ceae934625b46a2632 wpt-pr: 38097

… navigations. This came up during a spec PR review: WICG/nav-speculation#212 This is a reland of the following, except for extending the timeout. https://chromium-review.googlesource.com/c/chromium/src/+/4062248 Fixed: 1394569 Change-Id: I1ed952f6e1fc065a7213d262dfe5dc86f722f6c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4184810 Reviewed-by: Adithya Srinivasan <adithyas@chromium.org> Auto-Submit: Jeremy Roman <jbroman@chromium.org> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Cr-Commit-Position: refs/heads/main@{#1095624}

…can match traverse and reload navigations., a=testonly Automatic update from web-platform-tests prefetch: Add WPT showing that prefetch can match traverse and reload navigations. This came up during a spec PR review: WICG/nav-speculation#212 This is a reland of the following, except for extending the timeout. https://chromium-review.googlesource.com/c/chromium/src/+/4062248 Fixed: 1394569 Change-Id: I1ed952f6e1fc065a7213d262dfe5dc86f722f6c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4184810 Reviewed-by: Adithya Srinivasan <adithyas@chromium.org> Auto-Submit: Jeremy Roman <jbroman@chromium.org> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Cr-Commit-Position: refs/heads/main@{#1095624} -- wpt-commits: eb8a9702e01eb3ce887ab3ceae934625b46a2632 wpt-pr: 38097

jeremyroman added 8 commits November 15, 2022 18:18

partial fix to the prefetch response checks; still needs substantial …

46e44c6

…changes for redirect handling, process-a-navigate-fetch, etc

resolve a few items

3ea87dd

further tweak prefetch checks

32e59d4

substantial progress toward refactoring into a create-navigation-para…

d784c2e

…ms algorithm

more stuff around the prefetch serving code

c7dd79a

rewrite the prefetch algorithms

f404b7a

Merge branch 'main' into prefetch-6315

1ee9c20

resolve remaining todos

81e7ed4

mark one more section as an algorithm for var-highlighting goodness

d1a3c6d

jeremyroman requested a review from domenic November 18, 2022 01:55

domenic reviewed Nov 21, 2022

View reviewed changes

jeremyroman and others added 3 commits November 29, 2022 11:27

Merge branch 'main' into prefetch-6315

8447ca6

Apply suggestions from code review

3867b77

Co-authored-by: Domenic Denicola <d@domenic.me>

code review comments

1c5cca2

chromium-wpt-export-bot mentioned this pull request Nov 29, 2022

prefetch: Add WPT showing that prefetch can match traverse and reload navigations. web-platform-tests/wpt#37234

Merged

Merge remote-tracking branch 'origin/prefetch-6315' into prefetch-6315

8b41fff

jeremyroman and others added 4 commits November 29, 2022 14:11

Apply suggestions from code review

e5d499d

Co-authored-by: Domenic Denicola <d@domenic.me>

Don't use quotation marks for RFC8941 tokens

9936e2a

Co-authored-by: Domenic Denicola <d@domenic.me>

merge whatwg/html@3769dd0

4339f12

Merge branch 'prefetch-6315' of ssh://github.com/jeremyroman/nav-spec…

2abefe9

…ulation into prefetch-6315

jeremyroman commented Nov 29, 2022

View reviewed changes

chromium-wpt-export-bot mentioned this pull request Nov 30, 2022

Revert "prefetch: Add WPT showing that prefetch can match traverse and reload navigations." web-platform-tests/wpt#37248

Merged

domenic mentioned this pull request Dec 2, 2022

Add spec for referrer policy key #216

Merged

domenic reviewed Dec 2, 2022

View reviewed changes

merge prefetch logic into "create navigation params by fetching"

dc4a9a5

domenic approved these changes Dec 9, 2022

View reviewed changes

jeremyroman added 3 commits December 14, 2022 11:48

misc comments

e2d0f12

thread prefetch record as an optional parameter

7620724

roll in two trivial RFC 2119 issues to fix the build

788a2c7

jeremyroman merged commit ad7e007 into WICG:main Dec 14, 2022

jeremyroman deleted the prefetch-6315 branch December 14, 2022 17:10

chromium-wpt-export-bot mentioned this pull request Jan 22, 2023

prefetch: Add WPT showing that prefetch can match traverse and reload navigations. web-platform-tests/wpt#38097

Merged

hiroshige-g mentioned this pull request Apr 17, 2023

Use sourceDocument if set for prefetch lookup #267

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update prefetch spec after whatwg/html#6315. #212

Update prefetch spec after whatwg/html#6315. #212

jeremyroman commented Nov 17, 2022

jeremyroman commented Nov 17, 2022

jeremyroman commented Nov 17, 2022

domenic left a comment

domenic Nov 21, 2022

jeremyroman Dec 7, 2022

github-actions bot commented Nov 29, 2022

jeremyroman left a comment

jeremyroman Nov 29, 2022

domenic left a comment

domenic Dec 2, 2022

domenic left a comment

domenic Dec 9, 2022

jeremyroman Dec 14, 2022

Update prefetch spec after whatwg/html#6315. #212

Update prefetch spec after whatwg/html#6315. #212

Conversation

jeremyroman commented Nov 17, 2022

jeremyroman commented Nov 17, 2022

jeremyroman commented Nov 17, 2022

domenic left a comment

Choose a reason for hiding this comment

domenic Nov 21, 2022

Choose a reason for hiding this comment

jeremyroman Dec 7, 2022

Choose a reason for hiding this comment

github-actions bot commented Nov 29, 2022

jeremyroman left a comment

Choose a reason for hiding this comment

jeremyroman Nov 29, 2022

Choose a reason for hiding this comment

domenic left a comment

Choose a reason for hiding this comment

domenic Dec 2, 2022

Choose a reason for hiding this comment

domenic left a comment

Choose a reason for hiding this comment

domenic Dec 9, 2022

Choose a reason for hiding this comment

jeremyroman Dec 14, 2022

Choose a reason for hiding this comment