Change { replace: true } to { history: "replace" } #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can then introduce { history: "push" } which explicitly errors if we're in a convert-to-replace situation.
This also fixes a preexisting omission where we were not properly doing replace navigations before the document is loaded.
domenic
commented
Mar 24, 2022
| @@ -787,7 +810,7 @@ An <dfn>navigation API method navigation</dfn> is a [=struct=] with the followin | |||
|
|
|||
| 1. Let |info| be |options|["{{NavigationOptions/info}}"] if it exists; otherwise, undefined. | |||
|
|
|||
| 1. Let |historyHandling| be "<a for="history handling behavior">`replace`</a>" if |options|["{{NavigationNavigateOptions/replace}}"] is true; otherwise, "<a for="history handling behavior">`default`</a>". | |||
| 1. Let |historyHandling| be "<a for="history handling behavior">`replace`</a>" if |options|["{{NavigationNavigateOptions/history}}"] is "{{NavigationHistoryBehavior/replace}}" or if |document| is not <a spec="HTML">completely loaded</a>; otherwise, "<a for="history handling behavior">`default`</a>". | |||
There was a problem hiding this comment.
This is somewhat of a bugfix, in the sense that Chromium definitely already did this conversion, and I believe we have tests for it.
In Chromium, by default all before-load navigations are replacements, with a special exception for anchor clicks: see https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/core/frame/local_frame.cc;l=454;drc=a24520a700e2581395920c74d59a918aa60bd5c9 . However in the spec, each call site of the navigate algorithm independently changes historyHandling, except anchor clicks which do not.
natechapin
approved these changes
Mar 24, 2022
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Mar 31, 2022
Follows WICG/navigation-api#219. Bug: 1183545 Change-Id: I1e962de093ece36c0f4cdebfcf83a53b4910ea16
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Apr 1, 2022
Follows WICG/navigation-api#219. Bug: 1183545 Change-Id: I1e962de093ece36c0f4cdebfcf83a53b4910ea16
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Apr 1, 2022
Follows WICG/navigation-api#219. Bug: 1183545 Change-Id: I1e962de093ece36c0f4cdebfcf83a53b4910ea16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3564502 Reviewed-by: Nate Chapin <japhet@chromium.org> Commit-Queue: Domenic Denicola <domenic@chromium.org> Cr-Commit-Position: refs/heads/main@{#988142}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Apr 1, 2022
Follows WICG/navigation-api#219. Bug: 1183545 Change-Id: I1e962de093ece36c0f4cdebfcf83a53b4910ea16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3564502 Reviewed-by: Nate Chapin <japhet@chromium.org> Commit-Queue: Domenic Denicola <domenic@chromium.org> Cr-Commit-Position: refs/heads/main@{#988142}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Apr 1, 2022
Follows WICG/navigation-api#219. Bug: 1183545 Change-Id: I1e962de093ece36c0f4cdebfcf83a53b4910ea16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3564502 Reviewed-by: Nate Chapin <japhet@chromium.org> Commit-Queue: Domenic Denicola <domenic@chromium.org> Cr-Commit-Position: refs/heads/main@{#988142}
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Apr 11, 2022
…history }, a=testonly
Automatic update from web-platform-tests
Navigation API: change { replace } to { history }
Follows WICG/navigation-api#219.
Bug: 1183545
Change-Id: I1e962de093ece36c0f4cdebfcf83a53b4910ea16
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3564502
Reviewed-by: Nate Chapin <japhet@chromium.org>
Commit-Queue: Domenic Denicola <domenic@chromium.org>
Cr-Commit-Position: refs/heads/main@{#988142}
--
wpt-commits: b905dcaacc78838e9b0a70de4aa7ca9735e2b726
wpt-pr: 33461
jamienicol
pushed a commit
to jamienicol/gecko
that referenced
this pull request
Apr 14, 2022
…history }, a=testonly
Automatic update from web-platform-tests
Navigation API: change { replace } to { history }
Follows WICG/navigation-api#219.
Bug: 1183545
Change-Id: I1e962de093ece36c0f4cdebfcf83a53b4910ea16
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3564502
Reviewed-by: Nate Chapin <japhet@chromium.org>
Commit-Queue: Domenic Denicola <domenic@chromium.org>
Cr-Commit-Position: refs/heads/main@{#988142}
--
wpt-commits: b905dcaacc78838e9b0a70de4aa7ca9735e2b726
wpt-pr: 33461
mjfroman
pushed a commit
to mjfroman/moz-libwebrtc-third-party
that referenced
this pull request
Oct 14, 2022
Follows WICG/navigation-api#219. Bug: 1183545 Change-Id: I1e962de093ece36c0f4cdebfcf83a53b4910ea16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3564502 Reviewed-by: Nate Chapin <japhet@chromium.org> Commit-Queue: Domenic Denicola <domenic@chromium.org> Cr-Commit-Position: refs/heads/main@{#988142} NOKEYCHECK=True GitOrigin-RevId: 3c68dda182f3e2df5197b3c7e392868d1e060e9e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can then introduce { history: "push" } which explicitly errors if we're in a convert-to-replace situation. Closes #111.
This also fixes a preexisting omission where we were not properly doing replace navigations before the document is loaded.
Preview | Diff