Revamp intercepted-navigation scroll handling #239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes the default behavior of intercepted navigations with respect to scrolling in the following ways: * Scroll restoration is performed on reloads, not just traverses. * For pushes and replaces, we either scroll to the top or scroll to the fragment. This change requires some updated API surface: the scrollRestoration option to intercept() has become scroll, and the navigateEvent.restoreScroll() method has become navigateEvent.scroll(). The latter method now has more capabilities, working to give browser-default-like behavior for "push", "replace", and "reload" in addition to "traverse". Similar to before, all of this can be opted out of by using scroll: "manual". Closes #237 by giving an easy default behavior for SPA navigations with hashes. Closes #231 by making "push", "replace", and "reload" behave by default in an MPA-like manner with respect to scroll position, just like "traverse" does.
There was a problem hiding this comment.
@domenic could I interest you in a { scroll: 'auto' } default, that acts like after-transition, unless navigateEvent.scroll() is called before the intercept promise settles?
Hmm, I wonder if we should just make that the behavior of "after-transition"... |
|
Yeah, that makes sense |
natechapin
approved these changes
Jul 12, 2022
natechapin
reviewed
Jul 12, 2022
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Jul 20, 2022
Follows WICG/navigation-api#239 Intent to Ship: https://groups.google.com/a/chromium.org/g/blink-dev/c/DKeklNbLG5s Bug: 1345507 Change-Id: Id5c1b9d77953388dbe287f6403b0a49c8359d51b
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Jul 20, 2022
Follows WICG/navigation-api#239 Intent to Ship: https://groups.google.com/a/chromium.org/g/blink-dev/c/DKeklNbLG5s Bug: 1345507 Change-Id: Id5c1b9d77953388dbe287f6403b0a49c8359d51b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3758902 Reviewed-by: Chris Harrelson <chrishtr@chromium.org> Reviewed-by: Domenic Denicola <domenic@chromium.org> Commit-Queue: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/main@{#1026382}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Jul 20, 2022
Follows WICG/navigation-api#239 Intent to Ship: https://groups.google.com/a/chromium.org/g/blink-dev/c/DKeklNbLG5s Bug: 1345507 Change-Id: Id5c1b9d77953388dbe287f6403b0a49c8359d51b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3758902 Reviewed-by: Chris Harrelson <chrishtr@chromium.org> Reviewed-by: Domenic Denicola <domenic@chromium.org> Commit-Queue: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/main@{#1026382}
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Jul 22, 2022
…ation scroll handling, a=testonly Automatic update from web-platform-tests Navigation API: Revamp intercepted-navigation scroll handling Follows WICG/navigation-api#239 Intent to Ship: https://groups.google.com/a/chromium.org/g/blink-dev/c/DKeklNbLG5s Bug: 1345507 Change-Id: Id5c1b9d77953388dbe287f6403b0a49c8359d51b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3758902 Reviewed-by: Chris Harrelson <chrishtr@chromium.org> Reviewed-by: Domenic Denicola <domenic@chromium.org> Commit-Queue: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/main@{#1026382} -- wpt-commits: 5fb15e04adca47cc972a2e4c665853aca6a1a5b9 wpt-pr: 34919
jamienicol
pushed a commit
to jamienicol/gecko
that referenced
this pull request
Jul 27, 2022
…ation scroll handling, a=testonly Automatic update from web-platform-tests Navigation API: Revamp intercepted-navigation scroll handling Follows WICG/navigation-api#239 Intent to Ship: https://groups.google.com/a/chromium.org/g/blink-dev/c/DKeklNbLG5s Bug: 1345507 Change-Id: Id5c1b9d77953388dbe287f6403b0a49c8359d51b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3758902 Reviewed-by: Chris Harrelson <chrishtr@chromium.org> Reviewed-by: Domenic Denicola <domenic@chromium.org> Commit-Queue: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/main@{#1026382} -- wpt-commits: 5fb15e04adca47cc972a2e4c665853aca6a1a5b9 wpt-pr: 34919
mjfroman
pushed a commit
to mjfroman/moz-libwebrtc-third-party
that referenced
this pull request
Oct 14, 2022
Follows WICG/navigation-api#239 Intent to Ship: https://groups.google.com/a/chromium.org/g/blink-dev/c/DKeklNbLG5s Bug: 1345507 Change-Id: Id5c1b9d77953388dbe287f6403b0a49c8359d51b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3758902 Reviewed-by: Chris Harrelson <chrishtr@chromium.org> Reviewed-by: Domenic Denicola <domenic@chromium.org> Commit-Queue: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/main@{#1026382} NOKEYCHECK=True GitOrigin-RevId: d64518f92c71b650d1b5f83dbfae7d434bfc95bf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the default behavior of intercepted navigations with respect to scrolling in the following ways:
This change requires some updated API surface: the scrollRestoration option to intercept() has become scroll, and the navigateEvent.restoreScroll() method has become navigateEvent.scroll(). The latter method now has more capabilities, working to give browser-default-like behavior for "push", "replace", and "reload" in addition to "traverse".
Similar to before, all of this can be opted out of by using scroll: "manual".
Closes #237 by giving an easy default behavior for SPA navigations with hashes.
Closes #231 by making "push", "replace", and "reload" behave by default in an MPA-like manner with respect to scroll position, just like "traverse" does.
Preview | Diff