Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Save-Data and reference Client Hints #83

Merged
merged 1 commit into from
Apr 16, 2020

Conversation

yoavweiss
Copy link
Contributor

@yoavweiss yoavweiss commented Apr 16, 2020

Following comments on mozilla/standards-positions#117 I noticed that the spec is out-of-date on a couple of aspects:

  • Save-data has moved to its own spec, but wasn't removed from here.
  • The request headers are not properly defined as Client Hints.

This PR fixes that.


Preview | Diff

@@ -87,7 +87,19 @@
href: "https://tools.ietf.org/html/draft-grigorik-http-client-hints",
status: "Internet-Draft",
publisher: "IETF",
}
},
"CLIENT-HINTS-INFRASTRUCTURE": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably move this over to https://github.com/WICG/admin/blob/gh-pages/biblio.json

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do in a followup!

Copy link
Contributor

@marcoscaceres marcoscaceres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The removals + modifications look ok to me.

@yoavweiss yoavweiss merged commit 0746409 into WICG:gh-pages Apr 16, 2020
@yoavweiss yoavweiss deleted the cleanup branch April 16, 2020 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants