Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spec the switchMap operator #130

Merged
merged 4 commits into from
Apr 29, 2024
Merged

Spec the switchMap operator #130

merged 4 commits into from
Apr 29, 2024

Conversation

domfarolino
Copy link
Collaborator

@domfarolino domfarolino commented Mar 29, 2024

This PR spec's the switchMap() operator.

This PR closes #52 and makes progress on #126.


Preview | Diff

chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Apr 1, 2024
See WICG/observable#130 for the spec PR, and
https://chromium-review.googlesource.com/c/chromium/src/+/5381640 for
documentation about the `flatMap()` operator, which is structured in
almost the same way as `switchMap()`.

R=masonf@chromium.org

Bug: 40282760
Change-Id: Id2b0de2d60dd985be843f154bebd66f8948f36f3
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Apr 1, 2024
See WICG/observable#130 for the spec PR, and
https://chromium-review.googlesource.com/c/chromium/src/+/5381640 for
documentation about the `flatMap()` operator, which is structured in
almost the same way as `switchMap()`.

R=masonf@chromium.org

Bug: 40282760
Change-Id: Id2b0de2d60dd985be843f154bebd66f8948f36f3
aarongable pushed a commit to chromium/chromium that referenced this pull request Apr 1, 2024
See WICG/observable#130 for the spec PR, and
https://chromium-review.googlesource.com/c/chromium/src/+/5381640 for
documentation about the `flatMap()` operator, which is structured in
almost the same way as `switchMap()`.

R=masonf@chromium.org

Bug: 40282760
Change-Id: Id2b0de2d60dd985be843f154bebd66f8948f36f3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5410391
Reviewed-by: Mason Freed <masonf@chromium.org>
Commit-Queue: Dominic Farolino <dom@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1280836}
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Apr 1, 2024
See WICG/observable#130 for the spec PR, and
https://chromium-review.googlesource.com/c/chromium/src/+/5381640 for
documentation about the `flatMap()` operator, which is structured in
almost the same way as `switchMap()`.

R=masonf@chromium.org

Bug: 40282760
Change-Id: Id2b0de2d60dd985be843f154bebd66f8948f36f3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5410391
Reviewed-by: Mason Freed <masonf@chromium.org>
Commit-Queue: Dominic Farolino <dom@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1280836}
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Apr 1, 2024
See WICG/observable#130 for the spec PR, and
https://chromium-review.googlesource.com/c/chromium/src/+/5381640 for
documentation about the `flatMap()` operator, which is structured in
almost the same way as `switchMap()`.

R=masonf@chromium.org

Bug: 40282760
Change-Id: Id2b0de2d60dd985be843f154bebd66f8948f36f3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5410391
Reviewed-by: Mason Freed <masonf@chromium.org>
Commit-Queue: Dominic Farolino <dom@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1280836}
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Apr 10, 2024
…ble operator, a=testonly

Automatic update from web-platform-tests
DOM: Implement the `switchMap()` Observable operator

See WICG/observable#130 for the spec PR, and
https://chromium-review.googlesource.com/c/chromium/src/+/5381640 for
documentation about the `flatMap()` operator, which is structured in
almost the same way as `switchMap()`.

R=masonf@chromium.org

Bug: 40282760
Change-Id: Id2b0de2d60dd985be843f154bebd66f8948f36f3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5410391
Reviewed-by: Mason Freed <masonf@chromium.org>
Commit-Queue: Dominic Farolino <dom@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1280836}

--

wpt-commits: bd3b4d15f91c5b9b80295c81b890e45a44a9699a
wpt-pr: 45452
Copy link
Collaborator

@benlesh benlesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly okay, just a couple of things that I caught.

spec.bs Outdated Show resolved Hide resolved
spec.bs Outdated Show resolved Hide resolved
ErichDonGubler pushed a commit to ErichDonGubler/firefox that referenced this pull request Apr 15, 2024
…ble operator, a=testonly

Automatic update from web-platform-tests
DOM: Implement the `switchMap()` Observable operator

See WICG/observable#130 for the spec PR, and
https://chromium-review.googlesource.com/c/chromium/src/+/5381640 for
documentation about the `flatMap()` operator, which is structured in
almost the same way as `switchMap()`.

R=masonf@chromium.org

Bug: 40282760
Change-Id: Id2b0de2d60dd985be843f154bebd66f8948f36f3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5410391
Reviewed-by: Mason Freed <masonf@chromium.org>
Commit-Queue: Dominic Farolino <dom@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1280836}

--

wpt-commits: bd3b4d15f91c5b9b80295c81b890e45a44a9699a
wpt-pr: 45452
@domfarolino
Copy link
Collaborator Author

I think everything is addressed here so I am going to land this.

@domfarolino domfarolino merged commit 75d1e16 into master Apr 29, 2024
2 checks passed
@domfarolino domfarolino deleted the switchMap-operator branch April 29, 2024 15:27
github-actions bot added a commit that referenced this pull request Apr 29, 2024
SHA: 75d1e16
Reason: push, by domfarolino

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include switchMap operator?
2 participants