This repository has been archived by the owner on May 26, 2020. It is now read-only.
When should orientation = 'auto' be resolved? #15
Comments
|
The intention is to resolve it at construction time (similar to when the scrollSource isn't specified). You're right that this should be said explicitly in the spec. |
birtles
pushed a commit
that referenced
this issue
Nov 21, 2018
As specced this value causes implementation difficulties around the definition of 'scrollable' and the possibility of instability in the resultant ScrollTimeline (see issues #15 and #16). For now we have resolved to just remove it, with "block" becoming the default for a ScrollTimeline.' [ci skip] Generated from: commit f566763 Author: Stephen McGruer <stephen.mcgruer@gmail.com> Date: Wed Nov 21 13:21:43 2018 -0500 Remove 'auto' value for ScrollDirection (#32) As specced this value causes implementation difficulties around the definition of 'scrollable' and the possibility of instability in the resultant ScrollTimeline (see issues #15 and #16). For now we have resolved to just remove it, with "block" becoming the default for a ScrollTimeline.
|
Closing this since 'auto' has been removed from the spec. Issue #16 will remain open for now to track any re-implementation of 'auto'. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
This question came up during the Chromium implementation of ScrollTimeline. The definition of orientation states:
"auto
If only one direction is scrollable, selects that direction. Otherwise selects the direction along the block axis."
However it isn't explicit about when this direction should be selected. If a ScrollTimeline is constructed as follows:
var timeline = new ScrollTrigger({ scrollSource: scroller, orientation: "auto" })When should the orientation = 'auto' be resolved - at construction time, or every time currentTime is called? (Possibly changing from block to inline in the latter case, e.g. if the scroller content changes).
The text was updated successfully, but these errors were encountered: