Update explainer: Add 'Sec-' prefix to request header #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The request header added to requests that are eligible to write to shared storage via response header ought to be a "forbidden header" according to the [Fetch specification](https://fetch.spec.whatwg.org/#forbidden-request-header), i.e. a header that JS cannot add or modify. We were using `Shared-Storage-Writable` as the name of the request header, which was not a forbidden header and could be modified by JS. This commit adds the prefix `Sec-` in order to make this header forbidden, updating to using to using `Sec-Shared-Storage-Writable` as the header name.
|
@xyaoinum PTAL, thanks! |
xyaoinum
approved these changes
Oct 20, 2023
pythagoraskitty
added a commit
that referenced
this pull request
Oct 20, 2023
The request header added to requests that are eligible to write to shared storage via response header ought to be a "forbidden header" according to the [Fetch specification](https://fetch.spec.whatwg.org/#forbidden-request-header), i.e. a header that JS cannot add or modify. We were using `Shared-Storage-Writable` as the name of the request header, which was not a forbidden header and could be modified by JS. This commit is a followup to #120 and updates the specification draft to add the prefix `Sec-` in order to make this header forbidden. The new request header attached to eligible outgoing requests will be `Sec-Shared-Storage-Writable: ?1`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The request header added to requests that are eligible to write to shared storage via response header ought to be a "forbidden header" according to the Fetch specification, i.e. a header that JS cannot add or modify.
We were using
Shared-Storage-Writableas the name of the request header, which was not a forbidden header and could be modified by JS.This commit updates the explainer to add the prefix
Sec-in order to make this header forbidden. The new request header attached to eligible outgoing requests will beSec-Shared-Storage-Writable: ?1.We will update the specification draft accordingly in #121.