Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop inside attribute #211

Merged
merged 10 commits into from Nov 29, 2019
Merged

Drop inside attribute #211

merged 10 commits into from Nov 29, 2019

Conversation

jihyerish
Copy link
Collaborator

  • Drop inside attribute from spatialNavigationSearch
  • Move focus inside the element first
  • Consider the overlapped element
  • Modify the conventional test cases considering this change

Close: #210

Jihye Hong added 10 commits November 27, 2019 19:04
* Drop `inside` option
* Focus will always move inside the element first then outside
  (NOTE: As-is = focus always moves outside by default)
Move spatialNavigationSearch TCs in api-test.html to spatialNavSearch-test.html
* The previous result turns out because the calcution of distance function
* Drop inside attribute from spatialNavigationSearch
* Move focus inside the element first
* Consider overlapped element
@jihyerish jihyerish merged commit 274b177 into master Nov 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove 'inside' option from spatialNavigationSearch
1 participant