Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING CHANGE: Drop grammars #58

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

marcoscaceres
Copy link
Collaborator

@marcoscaceres marcoscaceres commented Aug 2, 2019

grammars are underspecified - they lack a format, so they are kinda useless... so removes grammars attribute, drops SpeechGrammarList, and SpeechGrammar.

Closes #32
Closes #57


Preview | Diff

grammars are underspecified - they lack a format, so they are kinda useless... so removes grammars attribute, drops SpeechGrammarList, and SpeechGrammar.
@saschanaz
Copy link
Contributor

What's the implementation status on Chrome? What does it support?

@foolip
Copy link
Member

foolip commented Aug 2, 2019

I'd like to hold off on removing this from the spec until I understand a bit better why this was added and if it ever worked, or perhaps still works on some platform.

@kdavis-mozilla
Copy link

kdavis-mozilla commented Aug 2, 2019

@foolip I'd speculate that when the spec was initially written, many years ago now, the production STT engines were not able to handle LVCSR and required grammars to get reasonable results. Things have changed somewhat now.

@marcoscaceres
Copy link
Collaborator Author

marcoscaceres commented Aug 5, 2019

Noting also that src attribute has implied fetching behavior and semantics, yet the spec doesn't actually specify how things are fetched, parsed, error handling (e.g., what happens if one fails, the rest download, is order significant, and so on), referrer policy, etc., etc. so, there is no way anyone implemented any of this in an interoperable manner.

Although well intentioned, fetching such grammars should really be done with fetch() or even good ol' xhr if dealing with XML.

@foolip
Copy link
Member

foolip commented Aug 5, 2019

@marcoscaceres there's no argument that the spec defines this well enough for interoperable implementation, and doing nothing wouldn't resolve #57. I've poked some more in #57 (comment) and my only concern with dropping this is what then happens with the implementation in Chromium, since I can't guess yet what the impact of removing it would be. Would you be OK with waiting for usage numbers before we axe it from the spec, to avoid flip-flopping? I'd of course not expect anyone to try implementing it in the interim, and warnings to that effect would be fine.

@marcoscaceres
Copy link
Collaborator Author

Yes, absolutely: no objection and no rush :)

@maccman
Copy link

maccman commented Feb 8, 2021

Any update? Does Chrome support SpeechGrammarList?

@yoavweiss yoavweiss changed the base branch from master to main March 5, 2021 21:38
@evanbliu
Copy link

evanbliu commented Nov 6, 2023

The WebSpeech API implementation in Chrome supports SpeechGrammarList. However, the backend speech recognition service does not so they don't actually do anything. I'm in favor of dropping this from the spec.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Define how grammars work and give examples
6 participants