Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specified the sink names to use for violation events. #194

Merged
merged 1 commit into from
Jul 18, 2019

Conversation

koto
Copy link
Member

@koto koto commented Jul 18, 2019

The logic is to fetch the sink name from the IDL construct identifier that has a [TrustedTypes] extended attribute (i.e. an attribute name, or function name), and to prefix it with an Element local name that the logic was applied to (or object constructor name if a context object is not an Element). eval is a special case, as it's not bound to any object.

Example sink names:

a.href
span.innerHTML
Window.open
Document.write
eval
Window.setTimeout

These sink names will be used when reporting violations (in a 'sample' field).

@koto koto merged commit 6f0f5b6 into w3c:master Jul 18, 2019
@koto koto deleted the sinkname branch July 18, 2019 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant